When downloading an order, manifest.json sometime overwrites contents of another file about porder HOT 7 CLOSED

Hi, just a note that I tested the proposed fix, and it seems to work fine. My team would really appreciate it if you could have a look at this soon, since we use porder in a production setting, and we currently have to use a workaround. Thanks a lot, we appreciate the work you put into this package!

from porder.

So here's a couple of things that are happening the downloader never downloads or attempts to download the manifest.json file, it simply uses it to get to the file names hence in line 184 it only passes out those files that don't end with manifest.json. So I am unclear here, it loses this functionality if the else is deleted in line 183 and ident is adjusted so it will try to download a manifest.json file. Can you send me a file where it tries to download the manifest.json file and saves it with a different file name?

from porder.

Hi Samapriya,
The command I run is porder download --url "https://api.planet.com/compute/ops/orders/v2/116f0a4a-2887-447e-a194-23ed14c69be4" --local "/serverdata/svs/tst"

These are the files I get:

And this is the metadata file (I had to rename it from .json to .txt to conform to GitHub upload rules)
20210524_095547_1038_metadata.txt

from porder.

Let me show you my reasoning.

Line 153: Loop over the files listed in the response to the GET request. (these files include manifest.json). Let's call this MAIN LOOP
Line 167: Let's take the case when manifest.json file is encountered, ...
Line 173: ...loop over the files listed in the manifest (these files do not include manifest.json), and create the local_path variable. Let's call this SUB LOOP Note that this variable is overwritten with every cycle of the SUB LOOP, so we when the SUB LOOP is finished, local_path has the value of the last item in the manifest.
Line 186: We are still in the MAIN LOOP and the "current" file is manifest.json. Therefore, the variable "url" contains the link to the manifest.json file
Line 190: We download the manifest.json file, but save it under a different filename, because the local_path variable was set to the filename of a different file on line 175.

Does that make sense?

from porder.

Thanks for the detailed comment, it would also be great to have you star the repo and cite the work as you are using it since you said you are using this for production code. This helps build stats, increases visibility, and encourages continuous development, would love to know which company is using this code is it SuperVision or something else? I will get the fix in soon

from porder.

Will do! Indeed, we are using porder at SuperVision Earth. Thanks a lot for maintaining the repo, it saves us a lot of work :)

from porder.

Now updated to porder v0.8.4 issue has been resolved based on discussion,thanks for feedback

from porder.