rake protractor:spec_and_cleanup doesn't actually run cleanup about protractor-rails HOT 7 CLOSED

Nope, doesn't sound like the intended behaviour to me. What do you get if you run

rake protractor:spec && rake protractor:cleanup ?

I know we have been playing with some optional args and things lately with the later releases so one of those features might have broken this convenience function.

What version of protractor-rails are you using?

from protractor-rails.

I'm using 0.0.8.
Running rake protractor:spec && rake protractor:cleanup also didn't work for me.

from protractor-rails.

Do you mean that there are still fixtures in your database after running
that?

On Wed, Nov 19, 2014 at 4:55 PM, Sami [email protected] wrote:

I'm using 0.0.8.
Running rake protractor:spec && rake protractor:cleanup also didn't work
for me.

—
Reply to this email directly or view it on GitHub
#19 (comment)
.

from protractor-rails.

Yeah, there are fixtures in there (which i would have expected after seeding it ;) ). However, there is also still test data in there as well (in my case for instance a test user that is created after a successful signup).
Judging from the output in my terminal im guessing the cleanup task simply didn't run.

Output:

Finished in 24.521 seconds
11 tests, 7 assertions, 1 failure

14:45:52.422 INFO - Executing: [delete session: 9120786f-c43f-45fd-9ca3-90268a71a95c])
14:45:52.995 INFO - Done: [delete session: 9120786f-c43f-45fd-9ca3-90268a71a95c]
Waiting to shut down cleanly.........
killing running protractor processes
kill protractor rails tests server...
kill: 5435: No such process
kill webdriver server...
kill: 5441: No such process
kill left over selenium processes...
Selenium Standalone has exited with code null
kill: 5447: No such process

from protractor-rails.

I have noticed the same. Looks like the spec task is not completing ok, even though nothing is spit at the log, that makes the cleanup task not to get fired.
For instance, if you run rake protractor:spec && rake protractor:cleanup won't work either, but if you do rake protractor:cleanup && rake protractor:spec does indeed work.

One thing that caught my eye was pid's not found while attempting to kill them (like you show above). I have just created pull request #23 to fix that.

from protractor-rails.

Awesome. Thanks!

On 00:11, Thu, 1 Jan 2015 Fernando Di Bartolo [email protected]
wrote:

I have noticed the same. Looks like the spec task is not completing ok,
even though nothing is spit at the log, that makes the cleanup task not
to get fired.
For instance, if you run rake protractor:spec && rake protractor:cleanup
won't work either, but if you do rake protractor:cleanup && rake
protractor:spec does indeed work.

One thing that caught my eye was pid's not found while attempting to kill
them (like you show above). I have just created pull request #23
#23 to fix that.

—
Reply to this email directly or view it on GitHub
#19 (comment)
.

from protractor-rails.

Hey guys, I have just submitted pull request #24 which I believe should take care of this issue. What I am seeing is that spec task is always running system exit, preventing cleanup task to actually run afterwards.

from protractor-rails.