Allow a client to configure typescript.tsdk (similar to VS Code) about typescript-language-server HOT 4 CLOSED

I don't think it is a good idea to rely on own tsserver, as you mentioned it won't be forward-compatible.

from typescript-language-server.

Well, do you think tsserver tries to be backwards compatible? I don't see what guarantee you have that it will be. It seems dangerous to me to just pick a tsserver from the environment as you do here, since it might be a newer version than what you have tested against. It seems safer to me to bundle a tsserver installation, and if you're doing that, then you might as well use the code in-process, instead of starting up a separate tsserver.

A related issue is that if you support LSP's workspaceFolders feature, then you won't be able to use the tsserver from the project's node_modules, as you do here, since there will be multiple projects. See this issue.

Anyways if you strongly oppose this suggestion, then feel free to close this issue.

from typescript-language-server.

Well, do you think tsserver tries to be backwards compatible?

We are trying to align behavior with the VS Code extension. If they can assume that tsserver is backward compatible, I think we can too.

A related issue is that if you support LSP's workspaceFolders feature, then you won't be able to use the tsserver from the project's node_modules, as you do here, since there will be multiple projects. See this issue.

In VS Code a user is responsible to decide which tsserver should be used via workspace configurations. We can rely on LSP configurations capabilities as well. In the case, if a configuration is not provided we can either prompt a user via the custom request or a fall-back to the first tsserver.

from typescript-language-server.

It's already possible with --tsserver-path option. The tool can decide which tsserver to use and whether to let a user switch between them.

from typescript-language-server.