Git Product home page Git Product logo

Comments (15)

sandersn avatar sandersn commented on June 29, 2024 1

I've done the rename and created a new repo. I invited the current owners for now and will invite everybody else soon.

I'm going to move the non-package repos next.

from _discussions.

sandersn avatar sandersn commented on June 29, 2024

@blakeembrey This is the planning thread I said I would create.

from _discussions.

unional avatar unional commented on June 29, 2024

For 3. Currently since typing is deprecated, they are mostly installed by npm install types/XXX, i.e. installed directly as github source.
Of course, there might be existing typing users if the typing server run by @blakeembrey is still running.

from _discussions.

sandersn avatar sandersn commented on June 29, 2024

@unional so the package.json entry looks like, eg "mysql": "github:types/mysql" ? Actually, how does that avoid conflicts with the mysql package itself?

from _discussions.

sandersn avatar sandersn commented on June 29, 2024

oh, I see, after trying it, it's "@types/mysql": "github:types/mysql".

Compare this to the entry for Github Packages:

"@types/mysql": "^2.15.7"

Here, it's the configuration environment that redirects @types to github packages.

Edit: So I think projects may not be able to simultaneously use both the existing repo-as-packages and github-npm-packages, but one org can serve both kinds of projects.

from _discussions.

sandersn avatar sandersn commented on June 29, 2024

OK, here's a plan. Please comment if you're interested; I'll probably do this tomorrow or Monday if there's no discussion.

  1. Rename the Types org to typed-typings.
  2. Create a new Types org.
  3. Re-add all admins and members to Types.
  4. Transfer all repos except npm-* and env-*. There are only 23 of these.
  5. Create a new repo in Types, DefinitelyTypedMirror.
  6. Add @typescript-bot to Types/DefinitelyTypedMirror and give it a token with package publish rights. Hopefully no other rights, but I think Github may not have publish-only tokens yet.
  7. Have @typescript-bot start publishing all DT PRs both to npm in the @types scope AND to Github Packages ... also to the @types scope.

People can use the mirror by adding an .npmrc in their project with the text

registry=https://npm.pkg.github.com/types

Which redirects the @types scope to github.

from _discussions.

felixfbecker avatar felixfbecker commented on June 29, 2024

Curious, what’s the advantage of Github packages?

from _discussions.

sandersn avatar sandersn commented on June 29, 2024

npm is a good place for Typescript projects to consume packages from the @types scope, but Automatic Type Acquisition uses @types to improve the usability of JS editors — largely Microsoft editors. So it's fair to put the load of serving that on Microsoft's infrastructure. Fortunately Github Packages allows us to do that without changing the publishing infrastructure much.

Humans can still use @types from github, but that would only be needed if npm were to go away.

from _discussions.

blakeembrey avatar blakeembrey commented on June 29, 2024

@sandersn I am happy with the rename (make it typed-typings for legacy sakes, that was the old org name).

One issue we have is existing users of Typings API/registry, will they all break with the org rename? E.g. https://github.com/typings/registry? Not sure how GitHub handles renames when the old name gets claimed. Unfortunately Typings is still used in production by real people: typings/api#102 (I had hoped the API traffic I saw was legacy/bots).

from _discussions.

sandersn avatar sandersn commented on June 29, 2024

Well, the entries in typings look like this:

{
  "versions": {
    "1.6.15": "github:types/npm-big-integer#f6861ea9a7a9bb72f4001dadf03c0ffb14ef7584"
  }
}

All the repos that we move back to types will be fine. However, when I inspected a few entries, they all pointed to npm-* entries, which will be broken since their new location will be "github:typed-typings/npm-big-integer#...".

There are actually still updates to the npm-* packages too, seems like mostly from @unional. If there's still usage of these, shouldn't we keep them around? They're not going to interfere with the packages from Definitely Typed. I know they should be deprecated soon, but I don't necessarily want to deprecate them now. But because of their deprecation, I also don't want to put in much migration work.

I suppose I could update typings/registry -- that's just a sed command to replace types with typed-typings. What do you think?

@unional you probably have an opinion too.

from _discussions.

unional avatar unional commented on June 29, 2024

I basically just accepting PRs. Those are contributions made by users.

I personally don’t use those types.

:)

from _discussions.

unional avatar unional commented on June 29, 2024

About the npm-* naming, we made that change back then because there are libraries that live off of npm, e.g. those only published to bower, and some global ones.

from _discussions.

sandersn avatar sandersn commented on June 29, 2024

All right, I'm going to make the move. I made a PR on typings/registry that changes github:types back to github:typed-typings: typings/registry#1000.

from _discussions.

sandersn avatar sandersn commented on June 29, 2024

Actually, github redirects might make the registry references still work. Still, the PR was so simple that we might as well update the registry.

from _discussions.

sandersn avatar sandersn commented on June 29, 2024
  1. I moved the non-package repos as well as the package repos that didn't show up in typings/registry#1000. Most of those packages appeared in the registry, but misconfigured. So the right fix might be to fix the registry. This probably doesn't matter for unused packages in a deprecated registry, though.

  2. I invited all current owners and members.

  3. I started publishing @types packages. You can see them in the packages tab from types' org page. I haven't filled in the old packages so right now it's just the most-recently-published packages from Definitely Typed.

from _discussions.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.