Git Product home page Git Product logo

Comments (8)

armanbilge avatar armanbilge commented on September 13, 2024 1

Aha, this is annoying. Actually an admin should just remove this org-wide secret, we no longer use it. The original idea was to provide a quick way for an entire org to change from the legacy to s01 server without modifying every build.

to a github action variable

I wonder if these can be set globally. The secret was a bad hack ...

from sbt-typelevel.

zarthross avatar zarthross commented on September 13, 2024 1

I'm pretty sure you can set an org wide variable: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/variables#creating-configuration-variables-for-an-organization

from sbt-typelevel.

rossabaker avatar rossabaker commented on September 13, 2024 1

Okay, I just migrated the secret to an environment variable, org wide.

from sbt-typelevel.

rossabaker avatar rossabaker commented on September 13, 2024

Yes, org-wide environment variable is possible. I can find a reference to the secret in generated ci.yml -- is it going to break anything if we remove that?

from sbt-typelevel.

armanbilge avatar armanbilge commented on September 13, 2024

I can find a reference to the secret in generated ci.yml -- is it going to break anything if we remove that?

It's not, because we've already updated all the builds. sbt-typelevel now uses the s01 host by default, it no longer needs to be explicitly configured.

from sbt-typelevel.

armanbilge avatar armanbilge commented on September 13, 2024

Thanks! Let's keep this issue open until we change sbt-typelevel to read this from the env instead of the secret, but Darren's immediate problem should be resolved.

from sbt-typelevel.

zarthross avatar zarthross commented on September 13, 2024

We'll know for sure next time a release is cut or a PR is merged...

from sbt-typelevel.

zarthross avatar zarthross commented on September 13, 2024

This appears to be fixed now. Thanks all!

image

from sbt-typelevel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.