Git Product home page Git Product logo

Comments (7)

tpolecat avatar tpolecat commented on May 27, 2024

This comes up from time to time and I am in favor of merging.

from mouse.

benhutchison avatar benhutchison commented on May 27, 2024

from mouse.

danicheg avatar danicheg commented on May 27, 2024

It would be lovely if all syntaxes could be in one submodule. But that would mean a huge refactoring of Cats and Mouse both. And frankly speaking, it's hard to imagine this possible in the foreseeable future.
Speaking about maintaining costs, I don't really think it's high at the moment. And I guess most contributors likewise will try to add something in the cats.syntax rather than in Mouse, even if Mouse would be a Cats submodule. Just sometimes it's hard to get why syntaxes should be in Mouse and not in cats.syntax directly.
I'm not arguing against this merging. Just curious what this will mean to Mouse as a separate library.

from mouse.

johnynek avatar johnynek commented on May 27, 2024

I think the main motivation is the contributor experience: it's a bummer for new contributors to come to cats, send a PR, and then be told, uh... maybe send to this other repo instead (when I think the sometimes give up at that stage).

The secondary benefit is not having to do the work of publishing. We usually are in short supply of maintainers. So by merging into one repo we have less demand for maintainers (or put another way: we have a higher level of service for cats + mouse than we do today since we share the load).

But, if you don't want to, that's fine too. I'm not a mouse user and I guess I don't mind just being the guy telling people to send their PRs here.

from mouse.

armanbilge avatar armanbilge commented on May 27, 2024

The secondary benefit is not having to do the work of publishing.

The publishing situation in cats rn is much, much worse than mouse (I had to beg for months to get Cats 2.7.0 😉 ). Mouse is setup with sbt-typlevel-ci-release. I'm not sure if Cats is setup for CI release at all? In any case, that's a discussion for cats.

from mouse.

rossabaker avatar rossabaker commented on May 27, 2024

I feel good about Mouse's maintenance. Ben has been a quality maintainer for a long time, and Daniel has added fresh energy to multiple repos. If they're happy, I'm happy.

I find the contributor experience more compelling. Have we actually lost PRs in the Cats -> Mouse redirection? Or have we discouraged new contributors who thought they were going to get into the 4.6K Stars Club and ended up in the 290 Stars Club?

Is there any prospect of a breaking Mouse 2 before a breaking Cats 3? Seems unlikely, but a merger would make that painful.

from mouse.

benhutchison avatar benhutchison commented on May 27, 2024

OK, summing up. Atm releasing mouse via push tag is easier than releasing cats, so there's little efficiency gain by folding repos. Let's keep a watch on volume of contributor redirects from Cats to Mouse, and possibly reopen if it's large, but for now we'll continue status quo.

from mouse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.