Git Product home page Git Product logo

Comments (4)

armanbilge avatar armanbilge commented on July 17, 2024

Thanks for reporting! Since you've already identified the broken code, would you be interested to fix it as well? 😄

from fs2.

InversionSpaces avatar InversionSpaces commented on July 17, 2024

I am willing to provide a PR, but I am not quite sure how to fix that. I would just store user provided string inside Path, but the commit that added this sep drop is named bug fixing, so I guess it is needed for some reason to drop that sep?
d18ddd5#diff-9fdf8bd4af13b084b80dc62144301802026204db7caabef1b0bcd64ab84daefdL74

from fs2.

armanbilge avatar armanbilge commented on July 17, 2024

I am not quite sure how to fix that.

It's possible that we may need to special-case this scenario.

so I guess it is needed for some reason to drop that sep

Can't remember at this point 😅 😬 you can try undoing that and see if any tests fail, and why.

from fs2.

armanbilge avatar armanbilge commented on July 17, 2024

Aha, probably to match JVM behavior.

$ scala
Welcome to Scala 3.3.0 (17.0.5, Java OpenJDK 64-Bit Server VM).
Type in expressions for evaluation. Or try :help.

scala> java.nio.file.Paths.get("/foo/")
val res0: java.nio.file.Path = /foo

from fs2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.