Comments (8)
It is simply a case that has never been addressed. It makes sense to exit immediately if no connections are open, though.
from graceful.
Ah, right :-)
from graceful.
So, do you feel like implementing it or shall I try to dig into the code?
from graceful.
Interesting. This case is handled at https://github.com/tylerb/graceful/blob/master/graceful.go#L244. It should return immediately if no connections are present. Care to debug it?
from graceful.
Don't really have time right now, but I will take a look let's say tomorrow.
from graceful.
It's doing keepalive I guess.
$ make run
[negroni] Started GET /
[negroni] Completed 200 OK in 5.364411ms
[negroni] Started GET /bootstrap-3.3.4-dist/css/bootstrap.css
[negroni] Completed 200 OK in 290.399µs
[negroni] Started GET /bootstrap-3.3.4-dist/js/bootstrap.js
[negroni] Completed 200 OK in 178.651µs
[negroni] Started GET /js/jquery-2.1.4.js
[negroni] Completed 200 OK in 341.359µs
[negroni] Started GET /bootstrap-3.3.4-dist/css/bootstrap-theme.css
[negroni] Completed 200 OK in 177.584µs
[negroni] Started GET /bootstrap-3.3.4-dist/css/bootstrap-theme.css.map
[negroni] Completed 200 OK in 354.736µs
[negroni] Started GET /bootstrap-3.3.4-dist/css/bootstrap.css.map
[negroni] Completed 200 OK in 2.139425ms
[negroni] Started GET /favicon.ico
[negroni] Completed 0 in 20.705µs
^Clen(connections) = 6
from graceful.
That would do it. :)
from graceful.
🤦 :-)
from graceful.
Related Issues (20)
- Connections that were never activated should be considered idle HOT 1
- Help with behavior of Stop() HOT 8
- Zero downtime deployments HOT 1
- Tests fail with Go 1.10 HOT 1
- data race on srv.Server.ConnState = nil
- Go 1.8+ alternative
- use define logger
- Feature Request: A More Flexible Logging HOT 3
- Building the next major version of graceful HOT 5
- Using ListenLimit and TCPKeepAlive panics HOT 8
- Closing previously idle connection early HOT 14
- TLS doesn't support connection TCPKeepAlive Option HOT 8
- http2_test.go:52: Expected HTTP/2 connection to server, but connection was using HTTP/1.1
- How to disable http2 HOT 4
- Signaling a shutdown to goroutines
- how to add net/http/pprof HOT 1
- go vet notification: assignment copies lock value to *config: crypto/tls.Config contains sync.Once contains sync.Mutex
- Concurrent write/read on manual shutdown HOT 1
- Is there any possible way to change listening port without restarting go server HOT 1
- Support dynamic TLS certificates
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graceful.