Git Product home page Git Product logo

Comments (43)

twolfson avatar twolfson commented on July 24, 2024

I don't have any ideas if there isn't anything in the terminal/console about it =(

I will take a look by the end of next weekend

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

Took a look at reproducing this issue. Unfortunately, I was unable to reproduce. However, it reminds me of an issue we had in #29 which was resolved via an electron upgrade.

However, it looks like we are on the latest version of electron =( (~0.36.3 === 0.36.x, latest is 0.36.8)

https://github.com/atom/electron/releases

For our sanity, can you confirm the current version of electron via npm ls electron-prebuilt?

from google-music-electron.

p-j avatar p-j commented on July 24, 2024

Just reinstalled it and got

~/.nvm/versions/node/v5.6.0/lib
└─┬ [email protected] 
  └─┬ [email protected]
    └─┬ [email protected]
      └─┬ [email protected]
        ├─┬ [email protected]
        │ └─┬ [email protected]
        │   └─┬ [email protected]
        │     └── [email protected] 
        └─┬ [email protected]
          ├─┬ [email protected]
          │ └─┬ [email protected]
          │   ├─┬ [email protected] 
          │   │ └── [email protected] 
          │   └── [email protected] 
          └─┬ [email protected]
            └─┬ [email protected]
              └── [email protected] 

Tried to sign in, same problem.

Running Node v5.6.0 and npm 3.6.0 on Ubuntu 14.04.4

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

Are there any errors in the Developer Tools console or stderr?

from google-music-electron.

urandom avatar urandom commented on July 24, 2024

I'm only getting this error in the dev console, though it appears in the previous screen (the one with the login button):
Failed to find navigation button
/usr/lib/node_modules/google-music-electron/lib/browser.js:61

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

That is a tolerable error to occur before login as long as the page is still rendering =/

@urandom Are you experiencing the same white screen issue and are using 2 step auth?

@p-j If you reload the page after logging in (View -> Reload), does the page still show a white screen?

from google-music-electron.

urandom avatar urandom commented on July 24, 2024

@twolfson
Yes, I'm using two step, and I get a white screen after I log in (or directly, when I was still logged in). Incidentally, on a completely different computer, but with the same account, it works just fine. Could be because it might still be on an older checkout.

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

What OS's are the 2 computers running?

from google-music-electron.

urandom avatar urandom commented on July 24, 2024

The exact same OS, arch linux

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

Weird, it must be the electron version. Can you find out what versions of google-music-electron and electron they are running? (Help -> About google-music-electron)

from google-music-electron.

urandom avatar urandom commented on July 24, 2024

Where things still work, the about screen prints out:
Version: 2.6.0
Electron version: 0.34.5
Node.js version: 4.1.1
Chromium version: 45.0.2454.85

from google-music-electron.

urandom avatar urandom commented on July 24, 2024

It also works (on the working computer) with the system electron instance:
Version: 2.6.0
Electron version: 0.36.7
Node.js version: 5.1.1
Chromium version: 47.0.2526.110

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

I don't follow. What were your install processes for both of those versions?

from google-music-electron.

urandom avatar urandom commented on July 24, 2024

The first comment is the regular usage (using sudo npm install -g ...). I also have electron installed separately (sudo pacman -S electron) for my own testing. So I just ran gme with 'electron /usr/lib/node_modules/go...'

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

Ah, k. Can you try installing a downgraded version of google-music-electron on the non-working computer?

npm install -g [email protected]

from google-music-electron.

urandom avatar urandom commented on July 24, 2024

I'll try it tonight. I'll also try with the system electron version, since I haven't tested that

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

Fwiw, [email protected] deprecated a lot of modules in favor of a single electron module. We patched those deprecation warnings in [email protected]

https://github.com/atom/electron/releases/tag/v0.35.0

2.8.0...2.9.0

from google-music-electron.

urandom avatar urandom commented on July 24, 2024

On the non-working computer, it didn't work with the system electron instance, and it didn't work with v2.9.0

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

What about with a globally installed 2.6.0?

npm install -g [email protected]

from google-music-electron.

urandom avatar urandom commented on July 24, 2024

I only do globally installed. I made sure to remove every trace of gme beforehand (cache, config, the actual files)

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

Right but google-music-electron ships with a prebuilt version of Electron. In your comment you said you used a system electron instance =/

from google-music-electron.

urandom avatar urandom commented on July 24, 2024

I used both the system electron instance and the prebuilt one. With the system one, it was to make sure that, given identical electron versions, it would work like the one on the working system. It turned out not to be the case, since I still got the blank screen.

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

Ah, k. It sounds like we have an OS specific crash like in #29 which means we should report it. First, we have to verify that the problem is definitively Electron/Google Music. Can you follow the steps in this gist on the failing machine?

https://gist.github.com/twolfson/5df0d2a9653be92dbec0#file-readme-md

from google-music-electron.

p-j avatar p-j commented on July 24, 2024

I tried also 2.9.0 and 2.6.0
I'm running Ubuntu 14.04.4
Both are failing at the same stage.
It's potentially good to add that the welcome screen is in french, the connexion screen is in english and my google account is in english. I don't know if that can trigger anything weird on the way...

In the console I only get a Failed to initialize GMusic. Trying again in 1 second from lib/browser.js:82
I also have right from the start a Failed to find navigation button from lib/browser.js:61

from google-music-electron.

p-j avatar p-j commented on July 24, 2024

Also, the DOM is present, but nothing is rendered.

from google-music-electron.

p-j avatar p-j commented on July 24, 2024

When I run the gist, I have the connexion screen, I can proceed to submit email address and password, but it fails at the same point when I need to enter the 2-step code I received by text message.

from google-music-electron.

p-j avatar p-j commented on July 24, 2024

Also, when I start it I have this

(electron) companyName is now a required option to crashReporter.start
Starting application with process.versions: { http_parser: '2.6.0',
  node: '5.1.1',
  v8: '4.7.80.27',
  uv: '1.7.5',
  zlib: '1.2.8',
  ares: '1.10.1-DEV',
  modules: '47',
  openssl: '1.0.2e',
  electron: '0.36.10',
  'atom-shell': '0.36.10',
  chrome: '47.0.2526.110' }

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

While starting to submit a new issue on Electron, I found this issue:

electron/electron#4513

Due to @urandom having this problem machine specifically and me never being able to reproduce on Linux Mint, I have a feeling it's a distribution specific problem.

@urandom Can you compare system level dependencies between the 2 machines? I know for Debian packages this is via dpkg --list but I'm not sure about Arch.

from google-music-electron.

MarshallOfSound avatar MarshallOfSound commented on July 24, 2024

Just adding my 2 cents here, for some reason the login screen glitches with certain GPU drivers (who knows...)

If you start the electron app with --disable-gpu it works 🌵

from google-music-electron.

urandom avatar urandom commented on July 24, 2024

@MarshallOfSound
This solves the problem on an intel gpu. It also appears to only be needed for the actual 2-way auth step. Once you log in, you can start gme with gpu support, until you log out.
Since my problematic laptop also has an nvidia gpu, I ran gme through primusrun to force it to go through the nvidia one, and there I don't observe any problems.

Curious that on my working laptop the gpu is also an intel one, yes gme works despite the drivers for both being the same

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

We should probably report this to Atom or Chromium so it can get properly fixed =/

from google-music-electron.

p-j avatar p-j commented on July 24, 2024

It indeed work with the --disable-gpu flag.
As for myself, I'm running a Dell m3800 Developer Edition with the preinstalled Ubuntu 14.04.
It comes with both intel 4th Gen Integrated Graphics & an nVidia Quadro K1100M but I'm not using it since battery is more important to me and I don't need more than the Intel Graphics for writing code :)

In fact, its event possible the nVidia is not working at all as I've never tested it and some forum reports its not working out of the box. But it's a different story.

from google-music-electron.

urandom avatar urandom commented on July 24, 2024

seems both mine and @p-j's problematic machines have some sort of nvidia optimus or equivalent setup.

from google-music-electron.

liamdawson avatar liamdawson commented on July 24, 2024

Confirming the same experience as @p-j and @urandom.

from google-music-electron.

p-j avatar p-j commented on July 24, 2024

On my part I've moved to Google Play Music Desktop Player which works fine so far.

from google-music-electron.

g105b avatar g105b commented on July 24, 2024

I'm having the same issue. Ubuntu 16.04 64bit. npm version 3.5.2. node version 4.2.6. (non-configured basic install via apt install npm && npm install google-music-electron).

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

@g105b Are you seeing any errors in the developer console? What happens when you use --disable-gpu as recommended by the other comments?

from google-music-electron.

g105b avatar g105b commented on July 24, 2024

@twolfson Sorry, nothing output in terminal once loaded, and disabling the gpu doesn't do anything either. I run other electron apps successfully, such as Slack, Nylas and now Google Play Music Desktop Player.

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

Ah, not the terminal -- I meant Chrome Dev Tools' console (accessed via View -> Developer -> Toggle Developer Tools). That being said, it's been a while since we last upgraded Electron so I'll give that a whirl

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

Hmm, I tried upgrading to both [email protected] and @1.4.x but there seems to be something that prevents the processing from closing once I start playing music. It won't even halt on a SIGINT; I need to SIGKILL it =(

It's not specific to our repo as I reproduced the issue by launching a vanilla Electron application and navigating via window.location

I don't have time to look into this further tonight but I guess the Electron update is on ice until that's resolved =/

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

Decided to keep on digging and making progress, going to make a separate issue to prevent diverging from the main topic (#44)

from google-music-electron.

g105b avatar g105b commented on July 24, 2024

I'll try and get some time to look at the code at some point soon.

from google-music-electron.

twolfson avatar twolfson commented on July 24, 2024

We stalled out on Electron's GitHub issues with respect to #44 and blockers for our upgrade. We decided to finally implement a non-ideal workaround and released that today. We're now running [email protected] as of 2.15.0.

Can someone try this out and let us know if 2 factor auth yields a blank page?

from google-music-electron.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.