file_group_count exceeds MAX_FILE_GROUP_COUNT about unshield HOT 4 OPEN

Interesting. Are you able to share the installation files with me?

Increasing MAX_FILE_GROUP_COUNT will make unshield read more "file group" entries, and that will push "component" entries forward and that will cause a crash. These are listed by the g and c commands, respectively.

The reason less files are extracted than the file count can be found in the unshield_file_is_valid function. There are a number of cases where a file entry is not actually a file.

from unshield.

I have sent the entire iso (by torrent) to your email.

Using the original MAX_FILE_GROUP_COUNT set as 71, I can list the groups and components:

$ src/unshield g /mnt/1/data1.cab
...
1648 file groups

$ src/unshield c /mnt/1/data1.cab
...
1445 components

But with the above warning:

WARNING: self->file_group_count = 151

The invalid files (shown by a improvised printf call in unshield_file_is_valid function), sum exactly the initial ones:

$ src/unshield l /mnt/1/data1.cab | grep 'Invalid file' | wc -l
990

$ echo '19911 + 990' | bc -l
20901

And the cases, classified by increasing number in the branches starting at 1:

$ src/unshield l /mnt/1/data1.cab | grep 'Reason' | sort | uniq -c
    384 Reason 3
    606 Reason 5

For the reason 3, fd->flags has the flag FILE_INVALID, and for the 5, fd->data_offset is NULL.

from unshield.

Got it, thanks! I'll see if I can get it working this weekend!

from unshield.

Looks like I didn't get it working that weekend... Due to personal time priorities/constraints I need a PR to fix this, if it's still an issue.

from unshield.