Comments (2)
twmb
commented on June 24, 2024
Good find, this is from the idempotent request being retried.
In client.go,
622 if r.cl.shouldRetry(tries, err) || r.cl.shouldRetry(tries, retryErr) {
we hit this case when one or the other error is non-nil, and shouldRetry previously returned false unless it was truly retriable. Now it returns true due to what you found.
I chose true because no error should mean retriable, but I'm going to change it to false because we specifically only want to evaluate if a non-nil error is retriable.
from franz-go.
twmb
commented on June 24, 2024
I've tagged the fix in v0.11.1. v1 should be released either tomorrow or Monday (unless you find a very tricky bug 😄).
from franz-go.
Related Issues (20)
- Align connects metrics to prevent no data scenarios HOT 4
- Guidance on Manual Commit error with group consumer HOT 1
- record failed after being retried too many times HOT 2
- Metadata Refresh Does't Update Topic IDs After Topic Recreation HOT 3
- Library doesn't fail if it cannot update metadata HOT 1
- [CustomPartitioner] Help required HOT 2
- Inconsistent partitioning strategy HOT 6
- Batch and retry uncommitted records with group consumer and kotel HOT 6
- Kip-848: Next Generation Consumer Group HOT 4
- Consumer group rebalancing bug when switching from eager to cooperative consumers HOT 8
- topic creation configs HOT 3
- reverted offset commit in kafka HOT 2
- Clarification NoOffsetReset HOT 2
- v1.17 release status
- Support force using ListOffsetsRequest to fetch offset HOT 8
- kgo.FetchMaxPartitionBytes: increasing this option causes high memory usage HOT 3
- Any way to assign only commited offsets on rebalance? HOT 2
- Produce batch time metrics HOT 3
- OnPartitionsAssigned called twice for the same partitions HOT 6
- ListOffsetsAfterMilli returns unexpected results when called against kfake cluster
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from franz-go.