List partition reassignments by topic about franz-go HOT 7 CLOSED

Got it. Thank you for clearing this up! Really appreciate the quick response, too. ❤️

By the way I just tested this command and it silently doesn't work, similar to my code. It might be best to return an error here so the user knows that they must specify partitions with the topic name.
kcl admin partas list -t my_test_topic

from franz-go.

Are you specifying any partitions in these topics? If not, if you directly specify a topic at all, you also have to specify any partitions in that topic.

from franz-go.

The kcl implementation seems to work without specifying partitions, though. This part sets the partitions to nil if you only specify the topic name.

I've also tried this command and it works, which makes it all the more confusing why my code does not.
kcl admin partas list my_test_topic

from franz-go.

I just had to double check that myself because that sure did look confusing, but after staring at this code a bit, are you using the -t flag?

kcl admin partas list requires a -t flag to set the topics / partiitons to list -- I actually should change that code to cobra.ExactArgs(0) or, even better, just drop the -t flag and use the input arguments. I'm not sure why I didn't, but currently right now kcl is silently ignoring your topic and instead defaulting to everything because the -t flag is not used.

from franz-go.

Ah, it makes sense now! I wasn't using the -t flag so it was just defaulting to everything.
That probably means that the following command won't work, similar to my code.
kcl admin partas list -t my_test_topic

So just to clarify, the API requires all partitions to be specified? There is no way to say "give me all the partitions for this topic?"

from franz-go.

Yeah, I checked the Kafka source earlier once I saw this issue (and mildly remember checking it for my same confusion when I first implemented this in kcl). If you want all partitions for a topic, you'll have to issue a metadata request beforehand. I do a similar thing now in kcl misc list-offsets foo: https://github.com/twmb/kcl/blob/dad6a73ac64fbde24bc6a7774a57afb92fa46b3a/commands/misc/misc.go#L616

from franz-go.

I think I actually use the non-specified partitions in some handlers actually (notably that misc command, at least) ... but I should return an error when an empty partition list does nothing.

from franz-go.