Support for user-agent in AWS_MSK_IAM SASL mechanism about franz-go HOT 6 CLOSED

@gengjie segmentio's code retreives an aws.Credentials, which itself has AccessKeyID, SecretAccessKey, and SessionToken.

I show the same thing in my example here:

The benefit with this example is that the credentials can be loaded on every authorization. By requiring Credentials as input, I'm not sure the segmentio code handles key rotation / token refreshes.

from franz-go.

Yep, can do! I saw your comments on the commit I linked in the aws-msk-iam-auth issue. I think User-Agent is usually not included in the signing token.

From my reply on your comment:

Sure, I can add this. I can default to a package constant, and allow overrides via an optional UserAgent override in the Auth struct. I'd have to dig in again into the Java source to find the default UA, unless you have a better suggestion.

from franz-go.

I pushed 8900120, which should address this. Will tag in v0.7.5.

from franz-go.

@twmb Actually sorry to you, what you implement was totally different from java. And I think you misunderstood @grsubramanian . For java configuration, user doesn't need to configure awsAccessKey. If possible please reference here - segmentio/kafka-go@fcb5875 to implement. Thanks!

from franz-go.

And also suggest to reopen this issue, Thanks!

from franz-go.

@twmb Thanks! Got it!

from franz-go.