Return more descriptive error messages for kerr.Error about franz-go HOT 3 CLOSED

How about return fmt.Sprintf("%v: %v)", e.Message, e.Description) to result in UNKNOWN_TOPIC_OR_PARTITION: This server does not host this topic-partition. Also, should this be under a different method?

from franz-go.

Yes also fine. I think the default Error() return should be a more descriptive error message than just the error code, so no I think it shouldn't be a different method. Regarding errors I would also suggest to use a non pointer receiver so that the errors are compatible with errors package where I can use errors.As(). What do you think?

from franz-go.

I think the pointer receiver is still compatible with errors.As, because the example of errors.As in the errors package itself uses a pointer receiver:

var perr *os.PathError
if errors.As(err, &perr) {
	fmt.Println(perr.Path)
}

Admittedly, I haven't used errors.As yet. What's the benefit of a pointer receiver vs not? I know that, allocation wise, it's more beneficial to use pointers in interfaces rather than non-pointers, because non-pointers go through an indirect allocation (this is implied in staticcheck's SA6002, ref: https://staticcheck.io/docs/checks#SA6002).

from franz-go.