Backfill param is missing when re-connect. about hbc HOT 4 CLOSED

I noticed the same issue during Firehose testing. It appears that the issue is due to backoffMillis in BasicReconnectionManager being 0 for the first reconnection. It is only if the reconnect fails that backoffMillis is increased and estimateBackfill(tps) will result in a count > 0. This means that if a read times out or we get a gzip/ssl error (not uncommon), we'd be missing a few ms worth of tweets.

My solution to this was to write a custom ReconnectionManager that listens for DISCONNECT events. It then calculates the backfill based on tps * amount of time disconnected (i.e., currentTime - disconnectTime).

I'm still in the process of testing this, but so far so good

from hbc.

@scubasau thank you for your input, hope it can be fixed in next release.

from hbc.

Thanks for the analysis @scubasau — looks like a straightforward fix.

from hbc.

Should be fixed in the next release.

from hbc.