Comments (3)
I was thinking about changing of underlying array type to Vector in the second major revision of Juicy Pixels so I'd gladly accept the patch. And two separate patch would be better, allowing to separate refactoring from bugfix.
For the bug, my first version was using (!!!) = (!)
for debugging, and it didn't crash so I let it slip. I should refactor the table to get the index 0 based, avoiding ugly surprises in the future
from juicy.pixels.
The code in my pull request (#6) has a commented out version of iclip
that is implemented as a function. The active definition of iclip in
there should be index correct and requires almost no modifications
other than a minor tweak. So I left it in.
Is that okay?
Jason
On Sun, Jan 15, 2012 at 3:08 PM, Vincent
[email protected]
wrote:
I was thinking about changing of underlying array type to Vector in the second major revision of Juicy Pixels so I'd gladly accept the patch. And two separate patch would be better, allowing to separate refactoring from bugfix.
For the bug, my first version was using
(!!!) = (!)
for debugging, and it didn't crash so I let it slip. I should refactor the table to get the index 0 based, avoiding ugly surprises in the future
Reply to this email directly or view it on GitHub:
#5 (comment)
from juicy.pixels.
Fixed during the merge
from juicy.pixels.
Related Issues (20)
- Convert DynamicImage to Image a in Pixel class?
- PNG metadata reading HOT 1
- RGB to CMYK conversion is wrong
- Check image width on writePixel
- Transparent gifs
- EXIF files are misidentified as TIFF instead of JPEG in metadata
- `readMetadata`, without decoding image HOT 2
- Add option to apply JPEG rotation to image
- Width and height incorrect for exif image
- Loosen bounds on bytestring HOT 1
- What does this sentence means?
- Refine(cast) DynamicImage to specific Image HOT 1
- Read EXIF data also from PNGs
- Distortion (and possibly segfault) in decoding a certain JPEG HOT 2
- Impossible - typeOfData : Exifone
- Plans to encode webp? HOT 2
- Loosen bounds on Vector
- add "instance TestEquality Keys"
- Infinite loop in palettize
- The test suite never fails
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from juicy.pixels.