Git Product home page Git Product logo

Comments (6)

twcclegg avatar twcclegg commented on July 27, 2024 1

The wrapper is certainly an option, would want to use floating versioning to not need to update every time there's new metadata. This port tries to do it's best to stay true to the Java source and its API while also adhering to C# styles and paradigms. The builder for PhoneNumber is the only major place that those two are particularly at odds. I use use phoneNumberUtil.Parse([E164 Number], null) in place of what ideally would be a constructor. The PhoneNumber class is autogenerated from the Google proto and I would rather not diverge from that.

from libphonenumber-csharp.

twcclegg avatar twcclegg commented on July 27, 2024

I see no reason why not, assuming that the migration path isn't too onerous. But given the age of the last release there's been quite a deal of updates it would be missing, 833 is the first thing that comes to my mind.

from libphonenumber-csharp.

wallymathieu avatar wallymathieu commented on July 27, 2024

Having a migration path would be nice. Another alternative is to use reimplement GlobalPhone as a set of extension methods and or wrappers to make it more c#-y.

from libphonenumber-csharp.

wallymathieu avatar wallymathieu commented on July 27, 2024

What do you think is the best way forward?

from libphonenumber-csharp.

wallymathieu avatar wallymathieu commented on July 27, 2024

Or is it only the builder that looks a bit non c#-y?

from libphonenumber-csharp.

wallymathieu avatar wallymathieu commented on July 27, 2024

Yes, that makes sense. I've not had the time to look into making any changes related to this.

from libphonenumber-csharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.