Comments (6)
The wrapper is certainly an option, would want to use floating versioning to not need to update every time there's new metadata. This port tries to do it's best to stay true to the Java source and its API while also adhering to C# styles and paradigms. The builder for PhoneNumber is the only major place that those two are particularly at odds. I use use phoneNumberUtil.Parse([E164 Number], null)
in place of what ideally would be a constructor. The PhoneNumber class is autogenerated from the Google proto and I would rather not diverge from that.
from libphonenumber-csharp.
I see no reason why not, assuming that the migration path isn't too onerous. But given the age of the last release there's been quite a deal of updates it would be missing, 833 is the first thing that comes to my mind.
from libphonenumber-csharp.
Having a migration path would be nice. Another alternative is to use reimplement GlobalPhone
as a set of extension methods and or wrappers to make it more c#-y.
from libphonenumber-csharp.
What do you think is the best way forward?
from libphonenumber-csharp.
Or is it only the builder that looks a bit non c#-y?
from libphonenumber-csharp.
Yes, that makes sense. I've not had the time to look into making any changes related to this.
from libphonenumber-csharp.
Related Issues (20)
- How to parse without getting exception for wrong format? HOT 10
- Country Code is added to NationalNumber in PhoneNumber Object if Number is too short HOT 1
- Could not load file or assembly 'System.IO.Compression HOT 6
- Document how changes in Google's base library are included or not HOT 2
- Strong named assemblies HOT 2
- Make metadata update and publish new version fully automatically HOT 1
- New Kazakhstan country code. HOT 1
- Could not interpret numbers after plus-sign when parsing +00000000000000 HOT 3
- Missing or invalid default region. HOT 2
- IsPossibleNumberForTypeWithReason returns valid mobile when IsValidNumber returns invalid HOT 1
- Valid US number is resulting in IsValid to false HOT 4
- Parsing phone number as valid when it starts with _ HOT 9
- GetNumberType always returns UNKNOWN HOT 2
- Breaking change in PhoneNumberUtil.Normalize HOT 2
- Enable nullable reference types
- American phone not correctly parsed? HOT 2
- Version 8.13.26 causes IndexOutOfRangeException HOT 3
- Vietnamese phone number does not validate HOT 1
- French mobile numbers with prefix "07" are not detected as mobile numbers HOT 2
- docs: codecov badge on README leads to old trunk branch "master" instead of the new "main" branch HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libphonenumber-csharp.