Git Product home page Git Product logo

Comments (3)

wpreimes avatar wpreimes commented on May 26, 2024

Also, maybe raise an Error if depth_from > depth_to and/or use abs values, because as far as I know there are no negative depths in ISMN. Currently if depth_from > depth_to it simply returns no ids after filtering.

from ismn.

wpreimes avatar wpreimes commented on May 26, 2024

Here https://github.com/TUW-GEO/ismn/blob/master/src/ismn/interface.py#L767 and here https://github.com/TUW-GEO/ismn/blob/master/src/ismn/interface.py#L424

from ismn.

wpreimes avatar wpreimes commented on May 26, 2024

This "feature" is already implemented for

ismn/src/ismn/interface.py

Line 372 in 9e1a358

def data_for_variable(self, variable, min_depth=None, max_depth=None):
but not in

ismn/src/ismn/interface.py

Line 707 in 9e1a358

def get_dataset_ids(self, variable, min_depth=0, max_depth=0.1,

I think we should also apply it to the second function and document that None is a valid input. But the default should not be None in the 2nd case.

from ismn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.