Git Product home page Git Product logo

Comments (6)

rezbyte avatar rezbyte commented on July 20, 2024

I cannot seem to reproduce this. In the second screenshot, it seems that the custom colors are disabled.

from tutanota.

charlag avatar charlag commented on July 20, 2024

Also on the first screenshot there clearly is a whitelabel theme, I will try to repro it as well but if not then I'd say it's okay

from tutanota.

murilopereirame avatar murilopereirame commented on July 20, 2024

I cannot seem to reproduce this. In the second screenshot, it seems that the custom colors are disabled.

Good catch, but the color was enabled on the web. Could be just a server delay?

Also on the first screenshot there clearly is a whitelabel theme, I will try to repro it as well but if not then I'd say it's okay

Yes, but should have two of them, one for mup4test and one for vaf

from tutanota.

rezbyte avatar rezbyte commented on July 20, 2024

Good catch, but the color was enabled on the web. Could be just a server delay?

So if I am correct, you had the both the web and Android clients open at the same time. The web client with the custom colors and the Android without. Is that right?

If that is the case, I do not think it is related to the onboarding wizard. The Android client was respecting the settings it had. This might be an issue about syncing user settings.

Yes, but should have two of them, one for mup4test and one for vaf

If the custom colors were disabled on the Android client, the vaf theme would not appear.

from tutanota.

murilopereirame avatar murilopereirame commented on July 20, 2024

So if I am correct, you had the both the web and Android clients open at the same time. The web client with the custom colors and the Android without. Is that right?

If that is the case, I do not think it is related to the onboarding wizard. The Android client was respecting the settings it had. This might be an issue about syncing user settings.

No, I setup the whitelabel on the web, put a nice color on it and after that I added the account to the android device and the theme wasn't shown up.

If the custom colors were disabled on the Android client, the vaf theme would not appear.

Yes, probably is related to the last question. Also the vaf theme took a while to appears into the wizard, I had to trigger the wizard 2/3 times

To be honest, maybe isn't a thing with the wizard itself, but with the load process of custom themes.

from tutanota.

charlag avatar charlag commented on July 20, 2024

I mentioned it but maybe only in person but the wizard page grabs only what is already loaded:
https://github.com/tutao/tutanota/pull/6785/files#diff-9bb05348e2e34585caf2fecc84648f110a3d340be0bc1f5b26c7cbe2e9a167dfR14

so it's probably a timing issue, whether PostLoginActions will add a theme first or not. We should probably make sure we do run storeNewCustomThemes() (or some alternative) when showing the wizard

from tutanota.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.