Git Product home page Git Product logo

Comments (9)

turnermm avatar turnermm commented on July 26, 2024

Can't reproduce this.

from ckgdoku.

jobhh avatar jobhh commented on July 26, 2024

I just made a new Dokuwiki install with only ckgdoku installed to test it. The issue also exists on this clean install.

I've giving edit rights to ALL on this page. HOST/dokuwiki/doku.php?id=ckgdokubug
Between these edits I only changed the number 1 into a 2, but ckgdoku also changed the URL: HOST/dokuwiki/doku.php?id=ckgdokubug&rev=1512491650&do=diff

Steps:

  1. Paste [[https://​l.facebook.com/​l.php?​u=https://test.com|https://test.com]] with the DW editor
  2. Save the page
  3. Now edit the page with ckgdoku. You can't only open and save it, you'll have to edit something (create a new line with a dot or something)
  4. Save the page, done.

from ckgdoku.

jobhh avatar jobhh commented on July 26, 2024

Another bug I just noticed. I assume this is a Dokuwiki bug and not ckgdoku.
The italic text in this page escapes the page content and makes the side menu and footer also italic... HOST/dokuwiki/doku.php?id=start 😛

from ckgdoku.

turnermm avatar turnermm commented on July 26, 2024

Your last "bug" seems to be a syntax error on your part.

The other issue is fixed, and just recently crept in when we added support for relative links.

from ckgdoku.

jobhh avatar jobhh commented on July 26, 2024

I can confirm that the URL processing bug is fixed. Thanks :)

True, that's a syntax error. I just assumed that Dokuwiki would restrict my syntax to the page content. It seems odd that page content can alter the content outside of the page. But that doesn't happen I just noticed.

The way that syntax got there does seem to be a ckgdoku bug though. That page's content was edited in ckgdoku when it changed from [[https://​​l.facebook.com/​​l.php?​​u=https://​test.com|https://​test.com]] to ''​https://​​l.facebook.com/​​l.php?​​u=https://​test.com''. However, I don't remember how it happened exactly. Maybe it's already fixed in the last commit. I'll let you know if I ever reproduce it.

Apart from ckgdoku, I do wonder why Dokuwiki renders ''​https://​​l.facebook.com/​​l.php?​​u=https://​test.com'' in a way the sidebar and footer become italic. It has an even number of //'s, both after a https:, but the second // seems to be ignored.

from ckgdoku.

turnermm avatar turnermm commented on July 26, 2024

Your example page previously was missing the opening ''

from ckgdoku.

jobhh avatar jobhh commented on July 26, 2024

I'm not sure how to interpret this, is it in response to the italic example page?

The start page HOST/dokuwiki/doku.php?id=start has this as source:
''​https://​​l.facebook.com/​​l.php?​​u=https://​test.com''

Which is rendered by Dokuwiki as this:
image

Can you explain this or shall I open an issue at dokuwiki?

from ckgdoku.

turnermm avatar turnermm commented on July 26, 2024

Dokuwiki is interpreting the two sets of forward slashes as markup:
https://​l.facebook.com/​l.php?​u=https://test.com
If you recast it as follows, you will not have that problem:
[[https://​l.facebook.com/​l.php?​u=https://test.com|facebook]]

Try it yourself, not in the ckgdoku editor, but in the native dokuwiki editor and use the preview to check the result.

from ckgdoku.

turnermm avatar turnermm commented on July 26, 2024

An d wither of these will work:
If you want the full text of the link:
[[https://​l.facebook.com/​l.php?​u=https://test.com]]
If you don't want it to be a link:
%%https://​l.facebook.com/​l.php?​u=https://test.com%%

from ckgdoku.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.