"arguments" column is always null in terraform_module table about steampipe-plugin-terraform HOT 8 CLOSED

Fixed in #36

from steampipe-plugin-terraform.

Hi @cmollet , thanks for raising this issue!

Are you seeing the arguments column come through correctly for other tables? Are there any other columns in the terraform_module table that aren't coming through correctly?

@rollwagen While developing the terraform_module table, do you recall if there were any caveats to the arguments column?

from steampipe-plugin-terraform.

Are you seeing the arguments column come through correctly for other tables?

Yes, the terraform_resource table works as expected.

Are there any other columns in the terraform_module table that aren't coming through correctly?

Does not appear so, but I don't have many modules that use a lot of for_each or depends_on

from steampipe-plugin-terraform.

@cmollet - thanks for bringing this up!

@cbruno10 / @cmollet - just had a look. In the PR for the terraform_module we did have some discussion around arguments and variables, see #28 (comment)
However, the arguments column wasn't added somehow (?).

Just tried adding the arguments column in the code, in the same way as it was done here https://github.com/turbot/steampipe-plugin-terraform/blob/main/terraform/table_terraform_data_source.go#L97

The result for the query

SELECT name, split_part(path, '/', -1), arguments FROM terraform_module ORDER BY name;

using the sample terraform code

module "test" {
  source           = "../../../modules/lambda"
  s3_bucket_name   = var.aws_s3_name
  publish          = true
  role_name_prefix = "role-"
  owner            = var.owner
}

would look like

+------+------------+----------------------------------------------------------------------------------------------------------+
| name | split_part | arguments                                                                                                |
+------+------------+----------------------------------------------------------------------------------------------------------+
| test | main.tf    | {"owner":"${var.owner}","publish":true,"role_name_prefix":"role-","s3_bucket_name":"${var.aws_s3_name}"} |
+------+------------+----------------------------------------------------------------------------------------------------------+

Happy to do a PR if this output is what you'd expect.

from steampipe-plugin-terraform.

@cmollet Thanks for investigating! Yes, I think those results match what we'd expect, e.g., any non-meta arguments would be returned in arguments.

If you have time, we'd love a PR, and if you need any help with it, please let us know!

from steampipe-plugin-terraform.

Thank you @rollwagen ! PR to fix would be great

from steampipe-plugin-terraform.

Thanks @rollwagen for the quick fix 👍.

from steampipe-plugin-terraform.

I can confirm it's fixed in 0.6.0! Thanks for the fix @rollwagen !!

from steampipe-plugin-terraform.