SyneditRegExpSearch.pas - empty patterns usage about synedit HOT 11 CLOSED

Could you please provide some more explanations. What is the expected outcome and what is the actual?

Also, what is the change you are suggesting?

from synedit.

Current situation, when roNotEmpty is included in default and you have no possibility to remove it leads to "wrong regular expression" message when you try to search for ^ or $ only. It disallows you insert content of the replace expression on any lines start or end.
Try my example with current Synedit version, remove roNotEmpty option (it's on 3 places in SynEditRegExpSearch.pas unit) and try it again. You will see the difference.

The change I suggest is remove roNotEmpty option, cause it's automatically added to any options you use.

from synedit.

I see...

cause it's automatically added to any options you use.

How do you conclude that?

from synedit.

constructor TSynEditRegexSearch.Create(AOwner: TComponent);
begin
  inherited Create(AOwner);
  fOptions := [roNotEmpty];
end;
...
procedure TSynEditRegexSearch.SetOptions(const Value: TSynSearchOptions);
begin
  if ssoMatchCase in Value then
    fOptions := [roNotEmpty]
  else
    fOptions := [roNotEmpty, roIgnoreCase];
  RegEx := TRegEx.Create(fPattern, fOptions);
  RegEx.SetAdditionalPCREOptions(PCRE_UCP);
end;

from synedit.

Just to make sure. Are you suggesting that we remove reNotEmpty from the constructor only and keeping it in SetOptions?

from synedit.

No, I mean remove it from constructor and set options. It has no influence of search.
Az alternative you can make it optional, but it means add property

from synedit.

But if I remove it from SetOptions it will never be set and empty matches could always happen.

from synedit.

This is what I wrote as alternative solution - make it optional (add property) in RegExp Synedit engine
Empty expression were there in the past before Delphi reg exp engine in Synedit.

from synedit.

Empty expression were there in the past before Delphi reg exp engine in Synedit

I could not find such an option in https://github.com/SynEdit/SynEdit/.

from synedit.

I committed anyway since your use case is common.
We should rethink how to expose roNotEmpty and other PCRE options to TSynEditRegexSearch.

from synedit.

Yes, in old implementation was no such options, but behavior was as I described

from synedit.