Comments (8)
Well it's your patch. I look forward to the upcoming release 👍
from parse-function.
🐯🐯🐯🐯🐯🐯🐯🐯
from parse-function.
Hey there! 👋 Thanks for the report, it sounds me like problem here.
I bet it's because of this here src/index.js#L106-L113.
The idea about that if
there, is if we have passed async method, then we should wrap it in object, so the parser can parse it correctly.
Can you try to add this check too and try again if it works
const isAsyncArrow = result.value.startsWith('async')
if (!(isFunction || isAsyncFn || isAsyncArrow) && isMethod) {
result.value = `{ ${result.value} }`
}
Another reason and probably limitation is that we use babylon.parseExpression
by default here, but as i remember, it was intentional.
from parse-function.
@charlike The patch works for me 👍 Thank you for the quick turnaround on that!
from parse-function.
Sweeeet! :D I love myself sometimes for such fast responses with good end :)
PR is welcome, otherwise i can push patch in coming days. Let me know if you need some help on contributing.
from parse-function.
@the1mills what? 😹 haha
@TooTallNate actually, yea, but it's not a problem for me. Go pr if you need it more soon.
from parse-function.
Please see #63.
@charlike P.S. I'd be happy to be added as a contributor, if this module has become a burden on your time.
from parse-function.
heya, just seen your comment here.
if this module has become a burden on your time
no, it's not, just i'm in period of switching ISP providers and following through smartphone is hard, haha.
i'll add you once I get stability and time, no problem :)
from parse-function.
Related Issues (20)
- Error when parsing a native function HOT 2
- Bug with arguments default value consisting of a list of expressions HOT 11
- fake issue
- v5.1.3 doesn't have a `dist/index.js` file HOT 5
- Ensure dist builds exists
- When default value consists of a list of expressions, default value is not returned as a string
- 5.2.0 has no dist folder HOT 4
- module and main entry points are not exporting the same API HOT 8
- Weekly Digest (10 February, 2019 - 17 February, 2019)
- Weekly Digest (17 February, 2019 - 24 February, 2019)
- Weekly Digest (24 February, 2019 - 3 March, 2019)
- Weekly Digest (3 March, 2019 - 10 March, 2019)
- Arrow function with inner function fails to parse HOT 7
- Function with named parameters is not parsed correctly HOT 1
- V5.3.2 Error: Cannot find module './utils' HOT 4
- Announcement (a bit late): moved to a `tunnckoCore/opensource` monorepo
- add "Plugins Architecture" and "Result" sections
- Parse bound functions HOT 8
- npm version and github release are not in sync HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from parse-function.