support id option about koa-better-ratelimit HOT 15 OPEN

Finally, v3 will come maximum at the end of the week. After I finish helapkg/hela#34.

from koa-better-ratelimit.

Yea, i see that when PR appears in koa-ratelimit and i'm thinking of it.

from koa-better-ratelimit.

It would be great if you can PR also with tests.

from koa-better-ratelimit.

Its not so easy because of using ipchecker's checks here

Hm.. okey, I'll look what can I create, as soon as possible. PRs welcome.

from koa-better-ratelimit.

@jedahan why you want to use koa-better-body?

from koa-better-ratelimit.

I'm confused what does koa-better-body has to do with my request. Unfortunately I don't have the time to submit a pull request, though I would like to. This is a request from a friend of mine, just trying to help him out :)

from koa-better-ratelimit.

Right.

I'm confused what does koa-better-body has to do with my request

It's simple, just limiting the requests per ip. And if he dont need to define custom error msgs, blacklisting ips, dont need db saving and etc, he should use some other simpler middleware

from koa-better-ratelimit.

Im thinking of to decouple it to separate modules at some point or concept for adding middleware to this middleware - i think it would be good. At this point we have tj's node-ratelimiter, but i believe it can be simpler.

from koa-better-ratelimit.

Ahh yes. That makes sense. Any middleware that can take a function, and yield a 429 ratelimit would do. Much simpler. Thanks for being patient explaining this to me.

from koa-better-ratelimit.

No worries. Try middlewares such as koa-ratelimit and koa-limit

from koa-better-ratelimit.

@jedahan I'll do this tonight and will release v3.0.0, because significant refactoring of the codebase and following ferver version scheme.

I'll start in clear v3 branch, stay tuned. Thank you guys!

from koa-better-ratelimit.

@tunnckoCore Do you have an ETA on when you plan on making v3 live? I need this feature as my server is sitting behind a load balancer and the IP address I need to rate limit is stored in X-Forwarded-For header.

from koa-better-ratelimit.

Do you have an ETA on when you plan on making v3 live

maximum the end of the week.

you may want to review https://github.com/tunnckoCore/koa-ip-filter

from koa-better-ratelimit.

+1. Would love to see this feature.

from koa-better-ratelimit.

@bishtawi @Popc0rn sorry guys but I have a bad cold. Try koa-ip-filter. :)

from koa-better-ratelimit.