Comments (3)
nh_listitem
is used in a lot of things, including a couple of structs used by options, which would involve changing a lot of network code. Moving enum options off of nh_listitem
to something new, or even to something like nh_menuitem
to support a new accelerator field would involve a fair amount of network code changes.
Putting this off for now.
from dynahack.
New idea: The accelerator for each enum option's entries could live in the first character of the caption string by convention. Not the prettiest design, but it'd require no protocol changes, and no code changes outside of handling of enum options. I might go ahead on this after all.
from dynahack.
I just tried doing this... the changes required were awful, since the choice descriptions for enum options are stored as-is in the game's config files. Also, generating unique accelerator keys for the dynamically-created 'race' and 'role' options was non-trivial, so I had to special-case them out in 3 different places across the front-end and back-end.
Putting this off again.
from dynahack.
Related Issues (20)
- also in terms of Grunthack enhancements (races?)
- Savegame corruption
- Bypass Thiefbane's two-hand requirement for One-Eyed Sam
- Being confused by an umber hulk does not stop travel
- Allow count with force-fight to limit the number of attacks used in melee
- Being stunned or confused still permits running/travel/autoexplore
- Vorpal Blade, Thiefbane and Mjollnir broken by artifact hit refactoring
- Kicking is stopped by safe_peaceful option
- '^' is not allowed as a shortcut when targeting for travel
- Position descriptions broken on the Plane of Water
- Exploding bags of holding do not affect engulfing monsters
- Ring of sustain ability can be used to exploit strength mod when becoming (un)weak from hunger
- Hero polymorphed into a disintegration dragon can walk through iron bars without affecting them
- Crash on level change, possibly related to multiple leashed pets HOT 3
- corpses rot way too fast sometimes HOT 3
- Polymorphed pet appears in its old form when being detected
- Arc quest nemesis levelports to the home level, crashes the game
- Trouble compiling on windows
- Crashes when loading any game (windows x86) HOT 2
- I like this but some things are strange (enhancement category)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dynahack.