Git Product home page Git Product logo

Comments (3)

tung avatar tung commented on July 21, 2024

nh_listitem is used in a lot of things, including a couple of structs used by options, which would involve changing a lot of network code. Moving enum options off of nh_listitem to something new, or even to something like nh_menuitem to support a new accelerator field would involve a fair amount of network code changes.

Putting this off for now.

from dynahack.

tung avatar tung commented on July 21, 2024

New idea: The accelerator for each enum option's entries could live in the first character of the caption string by convention. Not the prettiest design, but it'd require no protocol changes, and no code changes outside of handling of enum options. I might go ahead on this after all.

from dynahack.

tung avatar tung commented on July 21, 2024

I just tried doing this... the changes required were awful, since the choice descriptions for enum options are stored as-is in the game's config files. Also, generating unique accelerator keys for the dynamically-created 'race' and 'role' options was non-trivial, so I had to special-case them out in 3 different places across the front-end and back-end.

Putting this off again.

from dynahack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.