Documentation issue with /oauth/request_token about docs HOT 7 CLOSED

Thanks for creating this issue 👌

should be in JSON, if Content-Type is set to application/json

Can you clarify what you mean here? The endpoint should always return application/x-www-form-urlencoded as defined by the spec, and in my testing the response Content-Type is never application/json.

We'll merge an update to include the oauth_callback_confirmed response property, and indicate the response content type is application/x-www-form-urlencoded. Please let me know if that'll cover the items in this issue.

from docs.

Oh! Interesting!

I must've missed that in my fairly loose implementation of oauth 1.0a; I can see that I'm meant to send data via x-www-form-urlencoded (or query params), but if I send with Accept: application/json or Content-Type: application/json then the server doesn't reject the request, instead it just returns back application/x-www-form-urlencoded responses.

I'd been sending requests all with Accept: application/json, and was confused when I got back a different content-type; Perhaps returning a 406 Not Acceptable error if the Accept is sent and it is not application/x-www-form-urlencoded would be appropriate?

JSON APIs have spoiled me 😆

from docs.

Thanks for clarifying! We just merged an update to the docs: ef3f1b1, but I'll keep this issue open until we also implement the 406 response for the applicable routes 👌

from docs.

from docs.

I'm a little worried that the 406 response is going to be a breaking change
for clients that were unknowingly setting the Accept header previously

Agreed! Whenever we want to make this sort of change we log first to verify we won't break anything for anyone. If there are any hits we'll probably just drop the change, but we can also consider only enabling it for apps that are created going forward.

from docs.

Over the past few weeks we've had more than a handful of requests made to the /oauth/... endpoints with invalid accept headers. In the spirit of not breaking existing implementations we will not be introducing further changes at this time.

from docs.

from docs.