Comments (7)
Could you please provide an example that will enable me to replicate the problem?
from oasdiff.
Sure, this is what we are running (URLs changed for security purposes).
docker run --rm -t tufin/oasdiff -fail-on-diff -breaking-only -format html -filter "/api" -base https://qa-mycoolapi.azurewebsites.net/swagger/v1/swagger.json -revision https://dev-mycoolapi.azurewebsites.net/swagger/v1/swagger.json
Would always fail with:
Servers changed
- Deleted server: https://qa-mycoolapi.azurewebsites.net
But in reality that is expected as we are comparing against a deployed version that we know to be stable for backward compatibility issues. It would be nice to ignore that as a breaking change, something like '-exclude-servers' param would be perfect.
from oasdiff.
Looks like the spec files are in a private network.
Could you please copy them to a public location?
from oasdiff.
I am unable to provide real URLs for security purposes, however, I will attempt to make a few swagger.json files that reproduce the issue for you.
from oasdiff.
BaseAndRevisionSwaggerDefinitions.zip
Sorry for the zip, but GitHub wouldn't let me post json files.
Thanks again!
from oasdiff.
Fixed by #124
from oasdiff.
Pulled the latest version today and it works perfectly! Thank you so much :)
from oasdiff.
Related Issues (20)
- Can't use oasdif releases with version > 1.5.20 as a go module HOT 6
- What happened to v2 tags in docker hub? HOT 3
- ARM64 (Mac) docker image support HOT 1
- Output breaking changes in a copy/paste format for --err-ignore option HOT 3
- breaking-changes message format is wrong HOT 1
- Based on the same logic as request-property-one-of-removed is breaking, shouldn't this also be breaking?
- Edit changelog messages HOT 1
- 2x same param name in `components.parameters` triggers diff for identical `base` and `revision` HOT 1
- Trying to exclude number of paths from breaking command HOT 2
- Output breaking changes in JUnit format HOT 1
- Bug: Adding "data" envelope to response body is not breaking HOT 1
- Composed mode fails silently when glob doesn't match any file
- Group results by endpoint, change type, or other fields
- False positive breaking-changes when moving a param from endpoint to path level
- Improve cmd-line redaction for telemetry
- Add more languages to Breaking-Changes and Changelog
- major version changes HOT 6
- Add more details to Text/Markdown output. HOT 1
- --flatten flag throws stack overflow error HOT 2
- False-positive breaking change when adding `anyOf` to a response-property-type-changed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oasdiff.