Git Product home page Git Product logo

Comments (7)

reuvenharrison avatar reuvenharrison commented on May 26, 2024

Could you please provide an example that will enable me to replicate the problem?

from oasdiff.

bradleyquinn avatar bradleyquinn commented on May 26, 2024

Sure, this is what we are running (URLs changed for security purposes).

docker run --rm -t tufin/oasdiff -fail-on-diff -breaking-only -format html -filter "/api" -base https://qa-mycoolapi.azurewebsites.net/swagger/v1/swagger.json -revision https://dev-mycoolapi.azurewebsites.net/swagger/v1/swagger.json

Would always fail with:

Servers changed

But in reality that is expected as we are comparing against a deployed version that we know to be stable for backward compatibility issues. It would be nice to ignore that as a breaking change, something like '-exclude-servers' param would be perfect.

from oasdiff.

reuvenharrison avatar reuvenharrison commented on May 26, 2024

Looks like the spec files are in a private network.
Could you please copy them to a public location?

from oasdiff.

bradleyquinn avatar bradleyquinn commented on May 26, 2024

I am unable to provide real URLs for security purposes, however, I will attempt to make a few swagger.json files that reproduce the issue for you.

from oasdiff.

bradleyquinn avatar bradleyquinn commented on May 26, 2024

BaseAndRevisionSwaggerDefinitions.zip

Sorry for the zip, but GitHub wouldn't let me post json files.

Thanks again!

from oasdiff.

reuvenharrison avatar reuvenharrison commented on May 26, 2024

Fixed by #124

from oasdiff.

bradleyquinn avatar bradleyquinn commented on May 26, 2024

Pulled the latest version today and it works perfectly! Thank you so much :)

from oasdiff.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.