Git Product home page Git Product logo

Comments (12)

SuperOl3g avatar SuperOl3g commented on May 8, 2024

I can help and do this, but I wanna know your opinion about the concept.
You may have to rename your package according to this idea 🙂

from storybook-readme.

tuchk4 avatar tuchk4 commented on May 8, 2024

Hi,
I like this idea! But not sure if it is possible to implement (I mean dynamic panels)

Panels are registered after importing storybook-readme/register at .storybook/addons.js.

I think we can make it configurable:

import register from `storybook-readme/register`

register({
  panels: ['README', 'DOCS',  'CHANGELOG']
});

At stories:

const withChangelog =  storybookReadme.at('CHANGELOG');
const withReadme =  storybookReadme.at('README');

storiesOf('Button', module)
  .addDecorator(withChangelog(ButtonChangelog))
  .addDecorator(withReadme(ButtonReadme))

And we should hide panel if it is unused at active story.

from storybook-readme.

tuchk4 avatar tuchk4 commented on May 8, 2024

@ndelangen What do you think about this?

from storybook-readme.

SuperOl3g avatar SuperOl3g commented on May 8, 2024

Yeah, sounds good!
But AFAIU there is no possibility to hide panel if we have no content.

from storybook-readme.

tuchk4 avatar tuchk4 commented on May 8, 2024

@SuperOl3g if it is not possible to hide panels - this feature will be not so useful.

If there is story without docs / changelog / readme / etc. - all panels will be shown and with empty content.

But we can contribute to storybook :) Suggest "Hide panels" feature

from storybook-readme.

ndelangen avatar ndelangen commented on May 8, 2024

@SuperOl3g @tuchk4 I'm working on improving the extensibility of Storybook to make these things much easier. Not just to make addons hidable, I think that would be selling a faster horse.

What I'm working on is a re-implementation of the core ui layout. It would allow users to show multiple addons at once, in any split-configuration they please.

It's likely a 3.4 feature

from storybook-readme.

tuchk4 avatar tuchk4 commented on May 8, 2024

So multiple tabs with different docs will not be useful (until it is possible to hide tab if there is no assigned doc).

@SuperOl3g Actually we can implement tabs inside main tab.

image

If you would like to implement it - I will be happy. Consider that the same behaviour should be implemented for withDocs api.

from storybook-readme.

SuperOl3g avatar SuperOl3g commented on May 8, 2024

@tuchk4 Sorry, I think this solution doesn't look cool enough.
@ndelangen how can I help to implement new core API feature?

from storybook-readme.

tuchk4 avatar tuchk4 commented on May 8, 2024

This is feature is not useful until it is not possible to hide panels.
I close this issue for now.

Please reopen if you have another idea how to implement it :)

from storybook-readme.

SuperOl3g avatar SuperOl3g commented on May 8, 2024

affirmative)

from storybook-readme.

ndelangen avatar ndelangen commented on May 8, 2024

@SuperOl3g Join me on the Storybook slack and we can discuss how we can co-dev this feature.
https://now-examples-slackin-nqnzoygycp.now.sh/

I would be super happy to peer with you on this!

from storybook-readme.

ndelangen avatar ndelangen commented on May 8, 2024

I've opened a PR here:
storybookjs/storybook#2101

from storybook-readme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.