Comments (15)
Oh sorry I thought we were in electron's repo here 🤦♂️ my bad. You can probably reproduce the issue by running this library inside Electron's renderer process.
from camaro.
Looks like it's similar to this electron/electron#18540 but lemme dig deeper into this. I've never use Electron before.
from camaro.
Thanks for the quick reply, tuananh!
Here some more info about the environment:
- electron version: 9.2.1 (had version 7.x.x before, but same behavior)
I'm distributing the camaro.wasm to the app after build and I've seen you added a worker.js with v6, which seems to break the electron app. As far as I know, electron uses his own node & V8 engine version.
from camaro.
I'm also having an issue that might be related. I'm writing a Zapier CLI application and started getting this error immediately after trying to call transform()
Error: Cannot find module '/node_modules/piscina/dist/src/worker.js'
from camaro.
@kentico-ericd what node / camaro version are you using?
from camaro.
I tried
- camaro 6.0.3
- node 10.22.0
Does it require node >=12? I think it might have been an issue with zapier-platform-core
actually- if so, sorry for polluting the thread and I'll check with them :)
from camaro.
Workers should be stable with node >= 12.
@tuananh is it maybe possible to make the usage of workers for camaro optional? This could help with different environments and people can't argue about a lack in performance when workers are not in use.
from camaro.
from camaro.
Fixed by #122
from camaro.
Problem still occurs for me with the following versions:
- camaro 6.1.0
- Electron 10.1.3
The V8 platform used by this instance of Node does not support creating Workers
from camaro.
Stil happening v12
from camaro.
@AwesomeNameMan @fabiospampinato do you have minimal project so that I can try? I'm not very familiar with Electron.
from camaro.
Hi tuananh,
any news here?
from camaro.
Sorry i didn't have bandwidth for tis project lately. could you rollback to v3 where worker isn't used yet?
from camaro.
@tuananh i use camaro 3.0.19 There are still problems.
error: \\?\C:\Users\cd\AppData\Local\Temp\3809f2b1-9563-44e0-8d63-6b5673ffc4d6.tmp.node is not a valid Win32 application.
- camaro 6.1.0,6.2,5.0
- Electron 11.5
- node 12.18.3
from camaro.
Related Issues (20)
- Add ready to typing file HOT 2
- Module worker.js not found when using Typescript HOT 2
- Suggestion: Add `engines` field to package.json HOT 1
- Question: Template extraction HOT 1
- Undefined or missing elements parse as empty strings HOT 9
- Warning: (node:23080) ExperimentalWarning: The ESM module loader is experimental. HOT 1
- No result from transform [Help]
- Memory allocation error HOT 14
- Question: custom template HOT 2
- Dependencies not found (6.0.2) HOT 7
- benchmark HOT 5
- Unable to parse input with invalid characters HOT 5
- Use `piscina` only if `worker_threads` module is available
- Latest version very slow on AWS Lambda (node v14) HOT 3
- Template not working when using namespaces HOT 1
- XML with several deep nodes returns [Object] HOT 1
- Question - Nested Template HOT 2
- Sign npm release HOT 1
- Non support for non avx512 cpu flags HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from camaro.