timezone error in tNMEA0183Msg:makeTime(..) about nmea0183 HOT 4 OPEN

or better yet...

static inline time_t makeTime(tmElements_t &TimeElements) { return timegm(&TimeElements); }

from nmea0183.

a quick grep of the code shows localtime and mktime in other places. Might be a good to review the code for timezone issues.

from nmea0183.

I have to check - it is not that simple. In early days Arduino tim support was, what it was. It is important that any change does not cause incompamtibility to early versions so that it would suddently change behaviour in existing installations.

from nmea0183.

Arduino environment does not have timezone so that can not be used. I could bring timezone to library by with:

int32_t tNMEA0183Msg::GetTimeZone() {
  tmElements_t tme;
  SetYear(tme,1970);
  SetMonth(tme,1);
  SetDay(tme,2);
  SetHour(tme,0);
  SetMin(tme,0);
  SetSec(tme,0);

  return (int32_t )makeTime(tme)-SECS_PER_DAY;
}

If mktime implementation would have timezone in future also in Arduino, this should then work. Could you test that?
As addition there could be compiler definition
#if defined(linux)||defined(__linux)||defined(linux)
return timezone;
#else
...

from nmea0183.