q3map2 error: "ExpandPath called without qdir set" about gtkradiant HOT 2 CLOSED

Figured out the problem.

In ./tools/quake3/common/cmdlib.c, function ExpandPath(), the new code looks like this:

    if ( !qdir[0] ) {
            Error( "ExpandPath called without qdir set" );
    }

The old code:

    if (!qdir)
            Error ("ExpandPath called without qdir set");

Note that "!qdir" is always false because qdir is defined (as an address).

However, the only thing that ever modifies qdir is SetQdirFromPath() in the same file.

Found out that in q3map2 nothing ever calls SetQdirFromPath().

So "!qdir[0]" in the new code is always true so the error always happens.
We need to either revert to the old check or make sure that SetQdirFromPath() is called before ExpandPath() is used.

q3map2 is broken and people are complaining...

from gtkradiant.

Thanks. Removed the check.

from gtkradiant.