Git Product home page Git Product logo

Comments (5)

ttilley avatar ttilley commented on August 28, 2024

known, and not just rb-inotify. :-/

I got sidetracked with work on rb-fsevent, but started a cleanup of FSSM that lead to starting a rewrite which hasn't been pushed to a public repo yet. Anyways, the relevant line from the cleanup branch: https://github.com/ttilley/fssm/blob/cleanup/spec/monitor_spec.rb#L136

from fssm.

graaff avatar graaff commented on August 28, 2024

Thanks for the feedback. I've applied that patch in Gentoo and made the fssm package depend on rb-inotify, so that people will now automatically get the inotify support.

from fssm.

ttilley avatar ttilley commented on August 28, 2024

If that's the case, there are probably other commits on the cleanup branch you'd want to consider.

SHA: fbe274b
SHA: 6056bac
SHA: 946d747
SHA: c16bb27
SHA: e997e74 (the one mentioned above)

Note that the statements about rb-inotify only passing the test suite in JRuby no longer apply with the latest release of rb-inotify.

from fssm.

ttilley avatar ttilley commented on August 28, 2024

I'm making use of bundler to provide proper platform support when running rake and specs, which you don't care about in gentoo since you obviously only need the inotify backend.

from fssm.

graaff avatar graaff commented on August 28, 2024

We try to stay as close as possible to the upstream releases, so I'm going to pass on the additional commits. In Gentoo we offer our users the ability to runs tests automatically when installing, so I needed to apply that patch to get a passing test suite.

Also note that Gentoo can and does run on other kernels, e.g. on macos or even Windows, so we can't fully assume inotify-only. But we can't use bundler to install things either, so we need to solve all the dependency fun on our end anyway.

from fssm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.