Content Store is not getting a response value from sendMessage about webext-redux HOT 9 CLOSED

An update. Looks like both problem actions are actually aliases. The response is:

{ error: null }

from webext-redux.

Seems like I've figured it out. This happens when I don't return a dispatch within a redux-thunk function. For instance, if I have a thunk as follows:

export const someActionCreator = () => {
  return (dispatch, getState) => {
    if (<some_condition>) {
      return;
    }
    return dispatch({ type: SOME_ACTION });
  };
};

That premature return raises the error in this issue. If I swap it out with return dispatch({ type: '' });, it seems to work. This is strange though, and it seems like it's completely kosher to not dispatch (conditional dispatches) from within a thunk (unless I'm mistaken about that - I am still pretty new to redux).

from webext-redux.

So the issue seems to relate to the default promiseResponder here. If you don't call dispatch, then it looks like the result is returned as undefined (makes sense). I'm adding a simple work around now. Watch for a PR in the next couple minutes.

from webext-redux.

Awesome thank you @tshaddix! Appreciate the quick response!

from webext-redux.

This will be included in 0.0.8. Building release now.

from webext-redux.

💃

from webext-redux.

Done! Thanks for reporting, @vhmth !

from webext-redux.

https://www.opentest.co/share/a54ffc8059c911e6a1ffdd04f7a207b4

from webext-redux.

Sounds great! I'll be in SF in a couple weeks.

Also, sweet extension. Wonderfully clean experience!

from webext-redux.