Git Product home page Git Product logo

Comments (7)

josch avatar josch commented on August 28, 2024

it also doesnt work with any other libev since lenny (libev 3.43) until sid (libev 4.04) with the same error.

all define ev_invoke as void ev_invoke(ev_loop*, void*, int) in /usr/include/ev.h

I'm very interested in finding out what libev version is required so that ev_invoke accepts ev_async* as the first argument?

from node-sqlite3.

josch avatar josch commented on August 28, 2024

solved it.

the issue is, that debian distributes libev with EV_MULTIPLICITY enabled. this means that the ev_invoke function takes three parameters instead of the two provided in src/async.h where the first parameter is an ev_loop.

the author of node-sqlite seems to use a libev with EV_MULTIPLICITY disabled.

to make it work with both EV_MULTIPLICITY settings, one has to use the EV_DEFAULT_UC_ macro like this:

--- a/src/async.h
+++ b/src/async.h
@@ -53,7 +53,7 @@ public:
     }

     inline ~Async() {
-        ev_invoke(&watcher, ev_async_pending(&watcher));
+        ev_invoke(EV_DEFAULT_UC_ &watcher, ev_async_pending(&watcher));
         pthread_mutex_destroy(&mutex);
         ev_async_stop(EV_DEFAULT_UC_ &watcher);
     }

from node-sqlite3.

qbit avatar qbit commented on August 28, 2024

Yep, looks like that fixes it!

from node-sqlite3.

josch avatar josch commented on August 28, 2024

dude - why would you close a bugreport if it is not yet fixed???

from node-sqlite3.

qbit avatar qbit commented on August 28, 2024

lol, totally hit the wrong button :D

from node-sqlite3.

josch avatar josch commented on August 28, 2024

cool! now lets just hope that Konstantin is not too annoyed by all this spam in his inbox ^^

from node-sqlite3.

kkaefer avatar kkaefer commented on August 28, 2024

Sorry, this went under on my notifications page :/ I've been able to compile node-sqlite3 on lenny just fine, but since that code is what is implied anyway, I just committed this change in 6127c75 and published v2.0.14.

from node-sqlite3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.