Comments (8)
Need to wait until backbone is present. Currently the {{>flashes}} is compiled on pageload using pre-existing data. Saving, editing, etc is done async though.
from ghost.
Where are we on this, and can it be pushed to 0.3?
from ghost.
Working on this, expect a PR today - tomorrow.
from ghost.
Because notifications will be async, and client generated, a couple of questions:
- If I do something that generates a notification, and then do something else that generates another notification, do I end up with 2 flashes?
- Should notifications auto-clear?
- Should new notifications replace the previous one?
from ghost.
Notifications should have multiple states - passive, or persistent. Passive should disappear on the next pageload or user action, persistent should remain until manually dismissed by the user, with the "x".
Eg:
Your post was successfully published!
- Passive
Ghost 0.3.1 is available, please upgrade!
- Persistent
Multiple persistent notifications should stack, until dismissed.
There may be some UI / display issues with this. I'm thinking about a "notifications" wrapper that might solve a few problems, but for now let's just get it working functionally and then see here we are.
from ghost.
I've added a div just after the <main>
tag to accommodate the notifications and keep them in their separate world.
from ghost.
Just an update. Passive notifications are working perfectly. Working on persistent ones. Basically I need to replace the flashes
module with something else, plop the persistent ones on the ghost instance, and have logic to remove on user action. Hence PR is still not present.
from ghost.
Please resubmit this PR against the 'notifications' branch. Apologies I realise this will require some work due to the restructure :(
from ghost.
Related Issues (20)
- Integrations - FirstPromoter always showing as "active" HOT 2
- Admin API - Create Paid Members support HOT 1
- Node Version Requirement Not Declared Fine Enough HOT 4
- Wrong DNS records shown HOT 1
- Error updating to Ghost 5.80 from 5.23, blog down, please help HOT 1
- Comments broken in latest release HOT 5
- Internal tags not all displayed in admin panel
- Korean Romanization is Wrong HOT 3
- Ghost cannot connect to Mysql AWS RDS instance with latest CA from AWS HOT 2
- Handlebars special partial "@partial-block" gets reported as unknown global HOT 1
- Vulnerability Report: Regular Expression Denial of Service (ReDoS) in moment.js HOT 1
- Plain text view HOT 3
- Installation on Windows Fails with "A SystemError occurred." (nodejs version mismatch) HOT 1
- Newlines not correctly handled in product card titles
- Support Bluesky oEmbed auto-discovery HOT 4
- Editor tooltip for text styling is not visible when using android mobile
- Outdated version of string-width is causing the Docker image entrypoint loading to fail. HOT 2
- Site version in API not showing patch HOT 2
- glibc-vulnerability cve-2024-2961 [BUG] HOT 2
- Visitors on iOS prompted to download empty "auth-frame" file HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ghost.