Git Product home page Git Product logo

Comments (8)

javorszky avatar javorszky commented on May 7, 2024

Need to wait until backbone is present. Currently the {{>flashes}} is compiled on pageload using pre-existing data. Saving, editing, etc is done async though.

from ghost.

JohnONolan avatar JohnONolan commented on May 7, 2024

Where are we on this, and can it be pushed to 0.3?

from ghost.

javorszky avatar javorszky commented on May 7, 2024

Working on this, expect a PR today - tomorrow.

from ghost.

javorszky avatar javorszky commented on May 7, 2024

Because notifications will be async, and client generated, a couple of questions:

  • If I do something that generates a notification, and then do something else that generates another notification, do I end up with 2 flashes?
  • Should notifications auto-clear?
  • Should new notifications replace the previous one?

from ghost.

JohnONolan avatar JohnONolan commented on May 7, 2024

Notifications should have multiple states - passive, or persistent. Passive should disappear on the next pageload or user action, persistent should remain until manually dismissed by the user, with the "x".

Eg:

Your post was successfully published! - Passive
Ghost 0.3.1 is available, please upgrade! - Persistent

Multiple persistent notifications should stack, until dismissed.

There may be some UI / display issues with this. I'm thinking about a "notifications" wrapper that might solve a few problems, but for now let's just get it working functionally and then see here we are.

from ghost.

javorszky avatar javorszky commented on May 7, 2024

I've added a div just after the <main> tag to accommodate the notifications and keep them in their separate world.

from ghost.

javorszky avatar javorszky commented on May 7, 2024

Just an update. Passive notifications are working perfectly. Working on persistent ones. Basically I need to replace the flashes module with something else, plop the persistent ones on the ghost instance, and have logic to remove on user action. Hence PR is still not present.

from ghost.

ErisDS avatar ErisDS commented on May 7, 2024

Please resubmit this PR against the 'notifications' branch. Apologies I realise this will require some work due to the restructure :(

from ghost.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.