bug: Update to Set (with superjson) not triggering query about trpc HOT 7 CLOSED

You're free to make a PR to implement, but we'd have to update

• utils proxy
• any SSR fetcher
• all of useQuery/ useInfiniteQuery / [...]

Not sure if it's worth the squeeze, we've had 3 years of no one reporting an issue related to this so it feels like an edge-case and I'd like us to just piggy-back on RQ's hash fn that works great for the 99% use-case

AFAIK, you can still pass the hashQueryFn in tRPC as well as we just forward the options from RQ

from trpc.

If this is a bug, it's with 95% probability a bug in https://github.com/TanStack/query and not tRPC

from trpc.

Sandbox with raw RQ: https://stackblitz.com/edit/github-wgxcnf?file=src%2Findex.jsx

The first one represents the flow tRPC would work. We don't serialize the input before using is as a query key, so the query doesn't update.

We could "fix" this in trpc by transforming input before using is as a query key, although I'm not sure how wise that is 🤔

from trpc.

Yeah, this is most likely an issue in RQ's getQueryKey, but we shouldn't fix it in tRPC.

@BrendanC23 could you open an issue at https://github.com/TanStack/query using @juliusmarminge' sandbox above?

from trpc.

I created this React Query issue. They will not fix it on their end.

we only support json serializable values in the key. If you need something more, you can provide your own queryKeyHashFn and use something like superjson to serialize Sets.

from trpc.

Yeahhhhh..... I don't think we'll do this.

There are a lot of places we depend on the query hash being whatever RQ produces so I think it'll be quite hairy to make this work.

I'd advise you not to use Sets as an input argument. Personally, I only use JSON-serializable values as it maps better to React and <form>s etc, and if something needs to be a complex type, i use .transform(() => on code zod schema

from trpc.

This issue has been locked because we are very unlikely to see comments on closed issues. If you are running into a similar issue, please create a new issue. Thank you.

from trpc.