Git Product home page Git Product logo

Comments (4)

KATT avatar KATT commented on June 2, 2024 1

Your attitude and report is sub-par at best:

  • you don't clearly specify which typescript nor trpc versions you're using in the description so we're left guessing
  • your reproduction has a ^ in the package.json so we're left guessing
  • the repro didn't even use the latest trpc version in the package.json
  • you complain about a library you've never never contributed to, neither financially nor with work
  • this isn't even a bug due to trpc

We will, of course, fix it, which we already have in @next, but please spend more time understanding when your code broke, because it wasn't when you upgraded trpc.

This is due to breaking changes in TypeScript 5.4.0 and not in tRPC.

from trpc.

omridevk avatar omridevk commented on June 2, 2024

not sure how this got into a non beta release. Anyway, thanks for the great library!

from trpc.

omridevk avatar omridevk commented on June 2, 2024

Yes, I assume it came from my frustration.
I agree I could have improved the reported bug, but please hear me out, this is the third time I have been updating trpc and stuff breaks.
I totally agree that there's a way to say things and apologies if my comments seems disrespectful.
I do appreciate all your hard work and the fact that it is open source
If you look at my previous reported issues I have provided a lot of information.
#5034
#5037

In this case I thought just providing a reproducible example should suffice.

One thing to note, we have been using 5.x TS for a long time and this issue was not due to upgrading to TS 5.x from 4.x, maybe some minor version broke it, as it is known that TS is not semvar.

Again my sincere apologies for the way my comments came out, I will delete those.
Please keep up the great work :)

from trpc.

github-actions avatar github-actions commented on June 2, 2024

This issue has been locked because we are very unlikely to see comments on closed issues. If you are running into a similar issue, please create a new issue. Thank you.

from trpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.