Git Product home page Git Product logo

Comments (6)

TropheusJ avatar TropheusJ commented on June 26, 2024 1

new versions have been published. thanks for investigating.
This was caused by the class being renamed with the mappings change on forge 1.17.

from block_limit_fix.

TropheusJ avatar TropheusJ commented on June 26, 2024

Did you install the mod on the server or client? It's needed on the server.
This is a new error, but the same root issue. The server is sending the client invalid block data. This mod patches the only time this happens in vanilla, so I think some other mod has to be interfering. I do not think it's Create, it does not touch this area of code.
Also make sure you have the exact same mods and mod versions as the server.

from block_limit_fix.

vgrynch avatar vgrynch commented on June 26, 2024

Yes, I installed both client and server.
Yes, all versions match. Also, I have checked that all block and item ID tables match between the client and server (means, no content mismatching between mods).

As I described in the Creators-of-Create/Create#5419, I have tried to remove groups of mods and see if this stops happening. It did not work, but it was before I applied Block Limit Fix. I will try it again and let you know if there is any relation to some other mod. However, I doubt it, because the problem goes away as soon as I remove a number of mods, especially ones that add a lot of block states.

from block_limit_fix.

vgrynch avatar vgrynch commented on June 26, 2024

Removing sets of ~20-30 mods one by one did not help - the problem persist, so it is not some mod that is involved. (Or if there is such a mod, I have a few of them, that probably means some generic issue anyway.)

Today, after adding some more mods for heavy load/testing of the issue, I discovered that Diagonal fences and Diagonal Windows mods started to spoil blocks again (removing them stops blocks corruption.) More, there are no exceptions in the logs for this case. Block state change in the world (simply pressed that copper button from one of the mods!) turns that block into something else.

It means "Block limit fix" did not actually help here. It appears that the "too many states" issue is buried deeply in many places of the Minecraft code and packets.

If you want, I can network-debug the moment of the button pressing when it turns into something else. Can do the same for the contraption I described for Create mod (when exceptions appear). Unfortunately, I do not have a way to see/log packets content.

It looks like, for the time being, the only option for me right now is simply to reduce the number of mods, especially mods that add a lot of content. (Furniture mods will be my first target...) I will keep the "Block limit fix" mod for a while, just for a case :)

from block_limit_fix.

vgrynch avatar vgrynch commented on June 26, 2024

@TropheusJ, it appears this mod is not working under the 1.19.2 at all. Whatever I did, I'm getting the same result: blocks with high ID values are not correctly refreshed by Create mod. Digging a little bit more into the logs, I found the following messages related to the block_limit_fix loading:

[23Sep2023 13:53:01.583] [main/WARN] [mixin/]: Error loading class: net/minecraft/network/play/server/SMultiBlockChangePacket (java.lang.ClassNotFoundException: net.minecraft.network.play.server.SMultiBlockChangePacket)
[23Sep2023 13:53:01.583] [main/WARN] [mixin/]: @mixin target net.minecraft.network.play.server.SMultiBlockChangePacket was not found block_limit_fix.mixins.json:ClientboundSectionBlocksUpdatePacketMixin

Indeed, when taking a look inside of the ClientboundSectionBlocksUpdatePacketMixin.class, it contains a reference to SMultiBlockChangePacket.

What I suspect:
From what I saw, SMultiBlockChangePacket is a deprecated class that is no longer used in Forge 1.19*, at least I could not find it in the docs. It looks like this mod, while trying to support multiple MC versions, cannot load on 1.19.2 because of the above issue.

Please, can you create a separate dedicated 1.19.2+ version of this mod that will run correctly?

from block_limit_fix.

vgrynch avatar vgrynch commented on June 26, 2024

Made my own 1.19.2 build separately. It worked! Please, make an update.

from block_limit_fix.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.