Git Product home page Git Product logo

Comments (4)

ayusharma avatar ayusharma commented on August 29, 2024

@jamesb3ll @pago Should all mount decelerations without as key parameters have warning or should it only be in for-loops ?

I think, we can check this here

if (tokens.nextIf(Types.SYMBOL, 'as')) {

from melody.

efegurkan avatar efegurkan commented on August 29, 2024

Hey, @ayusharma

It should be for all of them AFAIK. It can be problematic in case of for loops, we are planning to enforce it.

from melody.

ayusharma avatar ayusharma commented on August 29, 2024

we are planning to enforce it.

It's better to throw an error in that condition.

Please let me know the error format.

I am thinking of this.

parser.warn({
              title: "Missing 'as' key with mount.",
              pos: tokens.la(0).pos,
              advice: "There should be an 'as' argumnet with a 'key' in mount statement."
            });

from melody.

pago avatar pago commented on August 29, 2024

Has been fixed by @ayusharma and will be part of Melody 1.2.0

from melody.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.