Inconsistencies in the way how `inputs` are handled in some hooks about melody HOT 5 CLOSED

What react does is, if you don't pass inputs it takes the first argument of the hook as input:

// useCallback
const inputsNext = inputs !== undefined && inputs !== null ? inputs : [callback];
const dirty = shallowEqualsArray(inputsNext, inputsPrev);

from melody.

Hey Malte 😃I've created a codesandbox to see React's behavior (open the console):
https://codesandbox.io/s/52ylkpl26p

From what I can see:

• useEffect(fn => cleanup(), inputs) will run fn on mount. Also, the cleanup function and fn will run on every update if inputs is an array of values that have changed (or is undefined).
• useMemo(fn, inputs) will re-run fn every time the inputs changes (or is undefined).
• useCallback(fn, inputs) is equal to useMemo(() => fn, inputs).

If any of the above are passed a constant array (eg. [] or ['constValue']) as inputs, then fn will only run once.

If on a re-render any of the above have inputs === undefined and fn is changed, the new fn will be run, so useEffect(fn) is actually useEffect(fn, [fn]).

I've not seen Melody's behaviour, but I presume it is different right now?

from melody.

I think it makes sense to align the behaviour. That'd make it more predictable.

from melody.

Hey @jamesb3ll 😍
yes, that's the behaviour that makes sense and that we also should implement. I will create a PR soon

from melody.

Has been fixed in #80

from melody.