[Bug] The query history UI should use externalUrl instead of backendUrl about trino-gateway HOT 5 OPEN

I can provide a PR to fix this as long as we decide on which of the two solutions you would like to use. Maybe @mosabua can chime in with a preference or route to the right folks?

from trino-gateway.

Hello, any ETA for this? It seems like even setting externalUrl to the gateway URL has no effect. It is probably using the backend URL anyway https://github.com/trinodb/trino-gateway/blob/49c5c82dbc18a50b9104d001917dc3139088a0da/webapp/src/components/history.tsx#L57C30-L57C47

from trino-gateway.

This issue is a bit complicated. Currently, we only store the backend_url in the query history table. Both backend_url and external_url can change at any time. This can lead to problems when the URLs are changed and the old backend_url in the query history no longer matches with the current setting.

Storing the foreign key gateway_backend.name in the query history table could solve the issue. We can get the latest backend_url and external_url for the cluster. For audit and debugging purposes, backend_url should also be kept for reference.

CREATE TABLE IF NOT EXISTS gateway_backend (
name VARCHAR(256) PRIMARY KEY,
routing_group VARCHAR (256),
backend_url VARCHAR (256),
external_url VARCHAR (256),
active BOOLEAN
);

CREATE TABLE IF NOT EXISTS query_history (
query_id VARCHAR(256) PRIMARY KEY,
query_text VARCHAR (256),
created bigint,
backend_url VARCHAR (256),
user_name VARCHAR(256),
source VARCHAR(256)
);

from trino-gateway.

@oneonestar thanks for detailed response. Do we have any ETA for that fix?

from trino-gateway.

It requires a database schema update and we haven't done that before...
I can bring up this issue in the next dev meeting to see how we can handle it.

from trino-gateway.