rename all functions with _ to proper names about trident HOT 5 OPEN

That's a pandoras's box that we'll get to, but we have other things to focus on, I'd make this a low priority.

from trident.

from trident.

One other big reason not to is because most of those functions are not really go-style functions as in the common Go sense.

Many are CLI commands others (H_/h_) are UI commands, they are not to be referenced outside the package anyway.

We'll likely get to a good part of changing this though with https://github.com/tridentli/pitchfork/milestone/3 when we change everything into separate packages, the way that is more go-style.

from trident.

I don't agree that 'not to be referenced outside the package' is a valid reason to avoid code quality/readability... If I send along pull requests for renames, will they be accepted? So far the renames I've got in my local repository are pretty simple, just there are a bunch of them :)

from trident.

I am all pro code quality and readability. The format of the CLI and UI functions grew over time (before we checked that go likes it differently).

We will re-architect things when 2.0 comes around, see amongst https://github.com/tridentli/pitchfork/milestone/3

and when that comes we'll modularize/package things and we'll also take care of all the non-standard golang function names.

Thus, no, in the current version we will not be changing those. There are more important things to do.

from trident.