MTKObserver should removeObserver in dealloc about block-kvo HOT 5 CLOSED

Yes, that would be great, but I remember I tried doing exactly this. The problem was, I think, that the KVO observances were checked before associated objects were released, which caused error logs to be printed to the console.

Maybe they changed deallocation implementation and it may work correctly now. Could you try it, please? If it works, open a Pull Request. It would be a great improvement.

Thanks.

from block-kvo.

Work for me. I have created a pull request, please check it.

from block-kvo.

Doesn’t work for me. Pull my changes and try adding these two lines to App Delegate in the Example app:

[self.property observeProperty:@"title" withBlock:^(id example, id old, id new) {}];
self.property = nil;

The first line will create an observer and the second will deallocate the Example object, which should remove observers. In my case, it crashed before -dealloc of MTKObserver was called.

from block-kvo.

since MTKObserver is element of a array which is a association object of target, MTKObserver's dealloc will delay to call until next runloop after target is dealloced. So I use deallocBlockExecutor as a helper to notify the related MTKObservers to detach ASAP.
I submit a another pull request. Please review it.

from block-kvo.

Done. It needed swizzling -dealloc, but I already has the implementation in another project.

from block-kvo.