Comments (5)
d-cogswell
commented on July 20, 2024
Maybe now is a good time to remove capFrac. It has been deprecated since 0.1.4.
from mpet.
lightningclaw001
commented on July 20, 2024
i feel like capfrac is still useful (like for example, if we use NMC batteries that need to be cut off at a certain voltage or capacity), are you sure we should just remove it?
from mpet.
d-cogswell
commented on July 20, 2024
The limits we need are voltage, time, and capacity. Right now we have voltage and time, and it would be good to add capacity. capfrac is really just another (confusing) way of implementing a time cutoff.
from mpet.
lightningclaw001
commented on July 20, 2024
yes, that makes sense! i will just remove it in this issue then.
from mpet.
lightningclaw001
commented on July 20, 2024
i think most of the test cases have capFrac in them so it changes the test case solutions, should we just rewrite all the test cases?
from mpet.
Related Issues (20)
- Add Csmax as an electrode property and deprecate rho_s
- Very stiff problem solver HOT 7
- CIET current expression HOT 6
- Numpy 1.24.0 breaks test005 HOT 1
- Pytest 7.0.0 and newer fail on Windows HOT 1
- Github actions need update HOT 1
- Half cell model voltage hold potential incorrect HOT 1
- Discharge current proportional to cathode thickness HOT 1
- Calculating ffrac from volume fractions
- Calculating reaction rate
- Thermal fluctuations for homogeneous models not working
- Animated plots crash starting with matplotlib 3.3.0 HOT 3
- Plot types csld_a and csld_c crash in v0.1.6 HOT 1
- Multiple output_data files in sim_output HOT 1
- colormap.npz file not found when using continuous plotting
- MPET matplotlib animation making depends on ffmpeg
- Always test all python versions
- Config params are saved before running simulation HOT 1
- Updates to Dockerfiles HOT 4
- Solver crashes during initialization when particle # above certain threshold HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mpet.