Comments (4)
@nicholasserra I forgot to link this issue to the associated PR. This one can probably be closed
from python-markdown2.
Tests currently failing in master
from python-markdown2.
I checked this out and the issue seems to be that pygments has started wrapping whitespace in span tags.
- <pre><span></span><code><span class="k">def</span> <span class="nf">foo</span>
+ <pre><span></span><code><span class="k">def</span><span class="w"> </span><span class="nf">foo</span>
- <span class="nb">puts</span> <span class="s2">"hi"</span>
+ <span class="w"> </span><span class="nb">puts</span><span class="w"> </span><span class="s2">"hi"</span>
<span class="k">end</span>
I think this is kinda cool as we don't have to worry so much about maintaining code block whitespace.
I've got a branch that fixes up the two affected test cases but what should be done about testing? I see three solutions: bump the required pygments version up and lose Py3.5 support, cap the maximum pygments version or update the test harness to only run the affected tests on a supported pygments version.
I think the latter would be doable, could use the existing tag system with the tests to tag certain test cases as pygments<2.14
and then check the installed pygments version matches that requirement
from python-markdown2.
Nice, thank you. Didn't have capacity to dive into this one lately, even if it's minor.
I think your idea of only running on affected versions is good, assuming that functionality is supported and it's not too much a pain. Otherwise I say just go path of least resistance. I've been chasing the pygments bump on this repo for a decade now so it's no big deal to have to keep dealing with it from time to time.
from python-markdown2.
Related Issues (20)
- Easy way to replace links to other markdown files to html files HOT 3
- Same header names generate identical HTML anchors HOT 1
- Footnotes in lists are numbered before other footnotes HOT 3
- Converting non-english anchor tags leads to "-x" values (or umlauts are replaced) HOT 2
- HTML headers not included in TOC
- Bad handling of two consecutive bold words HOT 6
- Fenced-code-blocks extra funky movments HOT 1
- Markdown Syntax Not Converted Within HTML Tags in markdown2 HOT 3
- Conversion Issue with Single Line Breaks in Lists and Tables HOT 2
- Table Conversion Issue with Trailing Spaces/Tabs
- Link Conversion Fails with Preceding or Following Square Brackets HOT 2
- Update markdown2 version on PyPI HOT 2
- Formatting error when input contains multiple words surrounded by triple asterisks HOT 2
- Conversion Issue with Single Line Breaks in Tables HOT 1
- Issue with Table Conversion - Last Row Not Converted HOT 1
- Update on PyPI and merge latest pull requests HOT 1
- Add typing to package HOT 3
- Unclosed HTML comments not being escaped with `safe_mode='escape'` HOT 3
- regression with markdown-in-html HOT 2
- How to format task list HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-markdown2.