Add mapstructure tags to config structures for viper config read package support about go-dcp-kafka HOT 5 CLOSED

@mhmtszr No we don't need to remove inline tag, we can use both yaml and mapstructure. With a tag like yaml:",inline" mapstructure:",squash" we can support both inline yaml and inline mapstrucure. I will implement and create pull request.

from go-dcp-kafka.

I can do this since it's 1 minute solution :)
Also we need this in go-dcp and other projects.

from go-dcp-kafka.

Thank you, I want to ask a question. If we did this, what would be their benefits?

from go-dcp-kafka.

Right now we can't read configs with viper package by just parsing viper data to config.Connector struct. If anybody wants to use viper it's not possible. In our team we use viper for dynamic configuration also and it will provide that.

Our current logic is parsing config file to another struct and map it to config.Connector.

I don't know if i explained well. I can provide more detail.

from go-dcp-kafka.

@emrekosen I understand your concerns you are right. If we remove the inline tag and add mapstructure, will it work the same? We need to test it. If you find an available time I would be happy to review your pull request.

from go-dcp-kafka.