Git Product home page Git Product logo

Comments (4)

playvue avatar playvue commented on August 15, 2024

Actually, since stopChannel only handles the channel being passed in, the current channel should probably be cleared at the end of SoundInstance.stop() prior to the return call.

from soundas.

treefortress avatar treefortress commented on August 15, 2024

Yep, good call, I've added that to the stop(). I couldn't reproduce this bug though, as stop() calls channel.stop(), which sets position=0, and should be enough to fail the isPlaying check.

Nonetheless, the old channel should be nulled out on stop as it no longer serves any purpose.

from soundas.

playvue avatar playvue commented on August 15, 2024

This is starting to seem like maybe "channel.position not being reset to 0" is a recurring problem with ASC 1.

Anyways, thanks! =)

from soundas.

playvue avatar playvue commented on August 15, 2024

It looks like the recent update to include stopAtZero on SoundTweens actually removed the fix put in place for this issue (channel = null in SoundInstance.stop). Is there are reason for this or was the issue just forgotten about since it's only an ASC1 issue?

from soundas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.