Git Product home page Git Product logo

Comments (13)

travs avatar travs commented on May 30, 2024

@dotnetdan
Hmm, what OS are you running?
Also, do you know if other languages show syntax highighting?

Thanks for the bug report!

from markdown-pdf.

dotnetdan avatar dotnetdan commented on May 30, 2024

I'm on Windows 7 64 bit.

I tried Python as well and had the same issue.

In editor:
image

PDF:
image

from markdown-pdf.

travs avatar travs commented on May 30, 2024

@dotnetdan
Ok, I think I know what the problem is, but to be sure could you open the developer console (View > Developer > Toggle developer tools) and give me the results of this command?

for(i of atom.themes.getActiveThemes()){console.log(i.name)}

from markdown-pdf.

dotnetdan avatar dotnetdan commented on May 30, 2024

Sure,

>for(i of atom.themes.getActiveThemes()){console.log(i.name)}
 solarized-dark-syntax VM954:2
 seti-ui VM954:2
 undefined

from markdown-pdf.

travs avatar travs commented on May 30, 2024

Ok, it's not what I thought but I believe I may have found a fix.

Will take some time to implement, but thank you for pointing this out 🐛

from markdown-pdf.

dotnetdan avatar dotnetdan commented on May 30, 2024

Ok, thanks. Let me know if I can help in any way. I am using this package a lot and would be glad to help.

from markdown-pdf.

travs avatar travs commented on May 30, 2024

Alright, I think I have it fixed now.

Grab v1.2.11 and have a look at the settings for this package (ctrl-,) and change Marked to Markdown-Preview under Rendering.

Let me know if this works/any bugs you see with it, and also if #21 is still a problem (I think it will be, but you never know).

Will probably implement as the default renderer instead of Marked if it ends up being stable.

Thanks for your help!

from markdown-pdf.

dotnetdan avatar dotnetdan commented on May 30, 2024

I'm not able to install it through the IDE. I keep getting this error:

Installing “[email protected]” failed.Hide output…

[email protected] install C:\Users\dling\AppData\Local\Temp\apm-install-dir-115012-14852-12l5vbb\node_modules\markdown-pdf\node_modules\html-pdf\node_modules\phantomjs
node install.js

npm http GET https://registry.npmjs.org/marked
npm http GET https://registry.npmjs.org/html-pdf
npm http 304 https://registry.npmjs.org/marked
npm http 304 https://registry.npmjs.org/html-pdf
npm http GET https://registry.npmjs.org/phantomjs
npm http 304 https://registry.npmjs.org/phantomjs
npm http GET https://registry.npmjs.org/adm-zip/0.4.4
npm http GET https://registry.npmjs.org/progress/1.1.8
npm http GET https://registry.npmjs.org/kew/0.4.0
npm http GET https://registry.npmjs.org/mkdirp/0.5.0
npm http GET https://registry.npmjs.org/npmconf/2.0.9
npm http GET https://registry.npmjs.org/request-progress/0.3.1
npm http GET https://registry.npmjs.org/request/2.42.0
npm http GET https://registry.npmjs.org/ncp
npm http GET https://registry.npmjs.org/rimraf
npm http GET https://registry.npmjs.org/which
npm http 304 https://registry.npmjs.org/mkdirp/0.5.0
npm http 304 https://registry.npmjs.org/adm-zip/0.4.4
npm http 304 https://registry.npmjs.org/kew/0.4.0
npm http 304 https://registry.npmjs.org/request-progress/0.3.1
npm http 304 https://registry.npmjs.org/progress/1.1.8
npm http 304 https://registry.npmjs.org/ncp
npm http 304 https://registry.npmjs.org/npmconf/2.0.9
npm http 304 https://registry.npmjs.org/rimraf
npm http 304 https://registry.npmjs.org/which
npm http 304 https://registry.npmjs.org/request/2.42.0
npm http GET https://registry.npmjs.org/throttleit
npm http GET https://registry.npmjs.org/minimist/0.0.8
npm http GET https://registry.npmjs.org/node-uuid
npm http GET https://registry.npmjs.org/caseless
npm http GET https://registry.npmjs.org/mime-types
npm http GET https://registry.npmjs.org/forever-agent
npm http GET https://registry.npmjs.org/bl
npm http GET https://registry.npmjs.org/json-stringify-safe
npm http GET https://registry.npmjs.org/qs
npm http GET https://registry.npmjs.org/tunnel-agent
npm http GET https://registry.npmjs.org/hawk/1.1.1
npm http GET https://registry.npmjs.org/aws-sign2
npm http GET https://registry.npmjs.org/form-data
npm http GET https://registry.npmjs.org/oauth-sign
npm http GET https://registry.npmjs.org/http-signature
npm http GET https://registry.npmjs.org/tough-cookie
npm http GET https://registry.npmjs.org/stringstream
npm http GET https://registry.npmjs.org/config-chain
npm http GET https://registry.npmjs.org/nopt
npm http GET https://registry.npmjs.org/ini
npm http GET https://registry.npmjs.org/osenv
npm http GET https://registry.npmjs.org/semver
npm http GET https://registry.npmjs.org/uid-number/0.0.5
npm http GET https://registry.npmjs.org/once
npm http 304 https://registry.npmjs.org/minimist/0.0.8
npm http GET https://registry.npmjs.org/inherits
npm http 304 https://registry.npmjs.org/forever-agent
npm http 304 https://registry.npmjs.org/bl
npm http 304 https://registry.npmjs.org/mime-types
npm http 304 https://registry.npmjs.org/caseless
npm http 304 https://registry.npmjs.org/node-uuid
npm http 304 https://registry.npmjs.org/json-stringify-safe
npm http 304 https://registry.npmjs.org/tunnel-agent
npm http 304 https://registry.npmjs.org/qs
npm http 304 https://registry.npmjs.org/hawk/1.1.1
npm http 304 https://registry.npmjs.org/aws-sign2
npm http 304 https://registry.npmjs.org/form-data
npm http 304 https://registry.npmjs.org/oauth-sign
npm http 304 https://registry.npmjs.org/http-signature
npm http 304 https://registry.npmjs.org/tough-cookie
npm http 304 https://registry.npmjs.org/stringstream
npm http 304 https://registry.npmjs.org/nopt
npm http 304 https://registry.npmjs.org/config-chain
npm http 304 https://registry.npmjs.org/ini
npm http 304 https://registry.npmjs.org/osenv
npm http 304 https://registry.npmjs.org/throttleit
npm http 304 https://registry.npmjs.org/semver
npm http 304 https://registry.npmjs.org/inherits
npm http 304 https://registry.npmjs.org/once
npm http 304 https://registry.npmjs.org/uid-number/0.0.5
npm http GET https://registry.npmjs.org/wrappy
npm http 304 https://registry.npmjs.org/wrappy
npm http GET https://registry.npmjs.org/proto-list
npm http 304 https://registry.npmjs.org/proto-list
npm http GET https://registry.npmjs.org/abbrev
npm http GET https://registry.npmjs.org/combined-stream
npm http GET https://registry.npmjs.org/mime
npm http GET https://registry.npmjs.org/async
npm http GET https://registry.npmjs.org/readable-stream
npm http GET https://registry.npmjs.org/asn1/0.1.11
npm http GET https://registry.npmjs.org/assert-plus
npm http 304 https://registry.npmjs.org/mime
npm http 304 https://registry.npmjs.org/abbrev
npm http GET https://registry.npmjs.org/ctype/0.5.3
npm http 304 https://registry.npmjs.org/async
npm http 304 https://registry.npmjs.org/combined-stream
npm http 304 https://registry.npmjs.org/asn1/0.1.11
npm http 304 https://registry.npmjs.org/ctype/0.5.3
npm http 304 https://registry.npmjs.org/assert-plus
npm http 304 https://registry.npmjs.org/readable-stream
npm http GET https://registry.npmjs.org/punycode
npm http GET https://registry.npmjs.org/delayed-stream/0.0.5
npm http 304 https://registry.npmjs.org/punycode
npm http GET https://registry.npmjs.org/core-util-is
npm http GET https://registry.npmjs.org/isarray/0.0.1
npm http GET https://registry.npmjs.org/string_decoder
npm http 304 https://registry.npmjs.org/delayed-stream/0.0.5
npm http GET https://registry.npmjs.org/cryptiles
npm http GET https://registry.npmjs.org/hoek
npm http GET https://registry.npmjs.org/boom
npm http GET https://registry.npmjs.org/sntp
npm http 304 https://registry.npmjs.org/string_decoder
npm http 304 https://registry.npmjs.org/core-util-is
npm http 304 https://registry.npmjs.org/isarray/0.0.1
npm http 304 https://registry.npmjs.org/boom
npm http 304 https://registry.npmjs.org/sntp
npm http 304 https://registry.npmjs.org/hoek
npm http 304 https://registry.npmjs.org/cryptiles

from markdown-pdf.

travs avatar travs commented on May 30, 2024

@dotnetdan

Apparently this is an issue with at least one other Win7 user.

Since apm apparently uses an older version of npm, this may be the source of the issue.

I will ping the apm team with an issue on this shortly, and see if we can't get this resolved.

from markdown-pdf.

Nicnl avatar Nicnl commented on May 30, 2024

The generated PDF have black text and the separator isn't rendering.

Original document:
md_1

Rendered PDF:
md_2


I've modified the .js script to output the html code.
md_3


Problem 1 in the output html/css:
md_4

Problem 2 in the output html/css:
md_5


Ugly fix in your .js:
md_6v2


Here's the fixed output pdf:
md_7


Apparently, markdown-pdf have some problems rendering :host and atom:// URLs.

from markdown-pdf.

dotnetdan avatar dotnetdan commented on May 30, 2024

@travs I discovered that the package wasn't installing due to a problem on my machine - my environment PATH was exceeding the maximum length allowed by Windows. After fixing that, I was able to install and test. Sorry about the false alarm!

My results are the same as reported by @Nicnl above.

from markdown-pdf.

travs avatar travs commented on May 30, 2024

@Nicnl

Hey thanks for the report 🐛
Could you make a pull request with those changes?

At least it works; we can focus on elegance later.

from markdown-pdf.

travs avatar travs commented on May 30, 2024

@dotnetdan
Going to close this now. Is the latest patch working for you?

from markdown-pdf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.