Comments (3)
Hey @bhugot,
I agree it's a bit inconvenient having to bring in a logging library just in order to use Hystrix when your actual application might be using a different logging library altogether.
What I can think of is instead of logging with log4net directly, just create our own IHystrixLogger
interface, use that to log inside Hystrix, and have a default implementation that just swallows the log messages (or writes to the console)
Then the users of Hystrix could provide an actual implementation of this interface (for example provide the type in the configuration), to specify how they want to log. And of course we can implement specific loggers ourselves for some logging libraries (like log4net) in extension packages. @JorritSalverda, what do you think?
from hystrix.dotnet.
@markvincze currently we don't collect those logs anyway.
Indeed we need to move to a logging abstraction. Maybe https://github.com/damianh/LibLog is useful for that or otherwise what you suggest.
from hystrix.dotnet.
@JorritSalverda Oh, nice, I didn't know about LibLog, it seems to be exactly what I had in mind. 👍
from hystrix.dotnet.
Related Issues (14)
- Hystrix.Dotnet.Samples.AspNetCore not working out of the box HOT 1
- [Question] Use of CancellationTokenSource HOT 2
- Stream metrics from console/windows application HOT 1
- [Questions] HystrixCommand Design Implementation HOT 3
- Owin middleware HOT 3
- Implement retry HOT 2
- Add example for fallback function to README.md HOT 1
- Create online documentation from docstrings HOT 4
- How to open the project HOT 1
- Signed Assembly not available in Nuget
- Execute method does not pass exception as a parameter in Fallback method
- ObjectDisposedException on .NET Core
- Add HystrixThreadPool to the stream HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hystrix.dotnet.