[github releases] show detailed error message on upload failure. about dpl HOT 5 CLOSED

I believe that you get a sane error message for invalid auth, uploading a file that already exists, and trying to upload a when you're not on a tag. I'll take a look at checking oauth scopes before uploading.

from dpl.

Hmm, I retried it a few minutes ago. I got a sane error message as @Joshua-Anderson say.
But, as I reported on #125, I couldn't get a sane error message on some cases.
I believe it isn't caused by network issues because my other network services are healthy.
Depends on upload file size?

from dpl.

I checked master branch.
It becomes to detect badcredentials.

/Users/monaka/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/octokit-3.1.0/lib/octokit/response/raise_error.rb:16:in `on_complete': GET https://api.github.com/user: 401 - Bad credentials // See: https://developer.github.com/v3 (Octokit::Unauthorized)
    from /Users/monaka/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/faraday-0.9.0/lib/faraday/response.rb:9:in `block in call'
    from /Users/monaka/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/faraday-0.9.0/lib/faraday/response.rb:57:in `on_complete'

But there was no detailed messages on duplicated uploads.

Deploying application
/Users/monaka/.rbenv/versions/1.9.3-p392/lib/ruby/1.9.1/openssl/buffering.rb:318:in `syswrite': Broken pipe (Errno::EPIPE)
    from /Users/monaka/.rbenv/versions/1.9.3-p392/lib/ruby/1.9.1/openssl/buffering.rb:318:in `do_write'
    from /Users/monaka/.rbenv/versions/1.9.3-p392/lib/ruby/1.9.1/openssl/buffering.rb:336:in `write'

I guess duplicated updates can be detected by calling HTTP HEAD method.

But it is caused by Faraday or something and/or OS dependent, I close this for now.
This issue is not critical to me.

from dpl.

I opened a PR #126 which should give a more logical warning when you don't have the proper scopes or try to overwrite a uploaded file.

from dpl.

@Joshua-Anderson , thanks for your improvements.
I'll try to execute dpl on Linux (instead of OSX) later. I want to tell you more information.

from dpl.